You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/03/30 07:59:33 UTC
[GitHub] [nifi-minifi-cpp] adam-markovics opened a new pull request #1290: MINIFICPP-1789 - Log checking is wrong in integration tests
adam-markovics opened a new pull request #1290:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1290
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni closed pull request #1290: MINIFICPP-1789 - Log checking is wrong in integration tests
Posted by GitBox <gi...@apache.org>.
adamdebreceni closed pull request #1290:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1290: MINIFICPP-1789 - Log checking is wrong in integration tests
Posted by GitBox <gi...@apache.org>.
adam-markovics commented on a change in pull request #1290:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1290#discussion_r838278891
##########
File path: docker/test/integration/MiNiFi_integration_test_driver.py
##########
@@ -248,7 +248,7 @@ def check_query_results(self, postgresql_container_name, query, number_of_rows,
assert self.cluster.check_query_results(postgresql_container_name, query, number_of_rows, timeout_seconds)
def wait_for_container_logs(self, container_name, log_pattern, timeout_seconds, count=1):
- self.cluster.wait_for_app_logs_regex(container_name, log_pattern, timeout_seconds, count)
+ assert self.cluster.wait_for_app_logs_regex(container_name, log_pattern, timeout_seconds, count)
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1290: MINIFICPP-1789 - Log checking is wrong in integration tests
Posted by GitBox <gi...@apache.org>.
fgerlits commented on a change in pull request #1290:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1290#discussion_r838256327
##########
File path: docker/test/integration/MiNiFi_integration_test_driver.py
##########
@@ -248,7 +248,7 @@ def check_query_results(self, postgresql_container_name, query, number_of_rows,
assert self.cluster.check_query_results(postgresql_container_name, query, number_of_rows, timeout_seconds)
def wait_for_container_logs(self, container_name, log_pattern, timeout_seconds, count=1):
- self.cluster.wait_for_app_logs_regex(container_name, log_pattern, timeout_seconds, count)
+ assert self.cluster.wait_for_app_logs_regex(container_name, log_pattern, timeout_seconds, count)
Review comment:
Good catch!
I would rename this function to `check_container_log_matches_regex`, as it does more than just wait for the logs. Also, it is the more general pair of `check_minifi_log_matches_regex`, similarly to the pair of functions `check_minifi_log_contents` and `check_container_log_contents`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org