You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/05/15 03:37:36 UTC

[GitHub] WillemJiang commented on a change in pull request #185: [SCB-245]: add acceptance test for dubbo demo

WillemJiang commented on a change in pull request #185: [SCB-245]: add acceptance test for dubbo demo
URL: https://github.com/apache/incubator-servicecomb-saga/pull/185#discussion_r188157504
 
 

 ##########
 File path: omega/omega-transport/omega-transport-dubbo/src/test/java/SagaDubboProviderFilterTest.java
 ##########
 @@ -45,7 +45,6 @@
   @Before
   public void setUp() {
     omegaContext.clear();
-    ApplicationContext applicationContext = mock(ApplicationContext.class);
 
 Review comment:
   JUnit always creates a new mock applicationcontext instance for the member field.  But this applicationContext is a different scope.  There is some miss part need to be add.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services