You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/04/28 21:54:38 UTC
[GitHub] [trafficserver] bneradt opened a new pull request #7758: Traffic Dump: Add an HTTP/3 AuTest
bneradt opened a new pull request #7758:
URL: https://github.com/apache/trafficserver/pull/7758
Adding an HTTP/3 test for Traffic Dump. This test is currently skipped
because ATS does not have the TS_EVENT_HTTP_SSN_* hooks implemented for
QUIC connections yet. Although the test is skipped, I plan to commit
this change now because it adds the following value:
* With minor modifications the test should work when these hooks are
implemented.
* The test can be used to help development when we decide to implement
these hooks for QUIC.
* This test provides an example AuTest for completed HTTP/3 transactions
which we currently do not have.
* This commit updates the Proxy Verifier extensions for HTTP/3 which will
be helpful for future QUIC tests using Proxy Verifier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on a change in pull request #7758: Traffic Dump: Add an HTTP/3 AuTest
Posted by GitBox <gi...@apache.org>.
maskit commented on a change in pull request #7758:
URL: https://github.com/apache/trafficserver/pull/7758#discussion_r626784158
##########
File path: tests/gold_tests/pluginTest/traffic_dump/replay/http3.yaml
##########
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+meta:
+ version: "1.0"
+
+ blocks:
+ - 200_ok_response: &200_ok_response
+ server-response:
+ status: 200
+ reason: OK
+ headers:
+ fields:
+ - [ Content-Length, 16 ]
+ - [ Connection, close ]
+
+sessions:
+- protocol: [ {name: http, version: 3},
+ {name: tls, sni: www.tls.com},
+ {name: tcp},
Review comment:
Right, it's always encrypted at least on version 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7758: Traffic Dump: Add an HTTP/3 AuTest
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7758:
URL: https://github.com/apache/trafficserver/pull/7758#issuecomment-893783538
Cherry-picked to 9.1.x, to resolve some merge conflicts for other PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on a change in pull request #7758: Traffic Dump: Add an HTTP/3 AuTest
Posted by GitBox <gi...@apache.org>.
bneradt commented on a change in pull request #7758:
URL: https://github.com/apache/trafficserver/pull/7758#discussion_r626779625
##########
File path: tests/gold_tests/pluginTest/traffic_dump/replay/http3.yaml
##########
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+meta:
+ version: "1.0"
+
+ blocks:
+ - 200_ok_response: &200_ok_response
+ server-response:
+ status: 200
+ reason: OK
+ headers:
+ fields:
+ - [ Content-Length, 16 ]
+ - [ Connection, close ]
+
+sessions:
+- protocol: [ {name: http, version: 3},
+ {name: tls, sni: www.tls.com},
+ {name: tcp},
Review comment:
Thank you for the observations,
Good point: in this case, the tcp is not used by Proxy Verifier. It is over UDP. That is: `{name: http, version 3}` dictates the whole stack which is over QUIC over UDP. I'll update that protocol node.
The `{name: tls}` node indicates the cryptographic characteristics of QUIC (SNI in this case). Does QUIC support unencrypted traffic? I think it has to be encrypted, yes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on a change in pull request #7758: Traffic Dump: Add an HTTP/3 AuTest
Posted by GitBox <gi...@apache.org>.
maskit commented on a change in pull request #7758:
URL: https://github.com/apache/trafficserver/pull/7758#discussion_r626766456
##########
File path: tests/gold_tests/pluginTest/traffic_dump/replay/http3.yaml
##########
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+meta:
+ version: "1.0"
+
+ blocks:
+ - 200_ok_response: &200_ok_response
+ server-response:
+ status: 200
+ reason: OK
+ headers:
+ fields:
+ - [ Content-Length, 16 ]
+ - [ Connection, close ]
+
+sessions:
+- protocol: [ {name: http, version: 3},
+ {name: tls, sni: www.tls.com},
+ {name: tcp},
Review comment:
H3 over TCP?
Also, I'm not sure if it should have tls. I can see the stack has sni key, but strictly speaking, tls is not on QUIC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt merged pull request #7758: Traffic Dump: Add an HTTP/3 AuTest
Posted by GitBox <gi...@apache.org>.
bneradt merged pull request #7758:
URL: https://github.com/apache/trafficserver/pull/7758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org