[GitHub] [hudi] XuQianJin-Stars commented on a change in pull request #4844: [HUDI-3450] Avoid passing empty string spark master to hudi cli

[GitBox <gi...@apache.org>]

XuQianJin-Stars commented on a change in pull request #4844:
URL: https://github.com/apache/hudi/pull/4844#discussion_r809650313



##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/utils/SparkUtil.java
##########
@@ -79,7 +79,9 @@ public static SparkConf getDefaultConf(final String appName, final Option<String
     if (properties.getProperty(HoodieCliSparkConfig.CLI_SPARK_MASTER) != null) {
       sparkMasterNode = properties.getProperty(HoodieCliSparkConfig.CLI_SPARK_MASTER);
     }
-    sparkMasterNode = sparkMaster.orElse(sparkMasterNode);
+    if (sparkMaster.isPresent() && !sparkMaster.get().isEmpty()) {

Review comment:
       !sparkMaster.get().isEmpty() ->  !sparkMaster.get().trim().isEmpty()




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org