You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/01/07 14:38:43 UTC
[GitHub] [phoenix] stoty opened a new pull request #1076: PHOENIX-3710 Cannot use lowername data table name with indextool
stoty opened a new pull request #1076:
URL: https://github.com/apache/phoenix/pull/1076
Co-authored-by: Ankit Singhal <an...@gmail.com>
Co-authored-by: Josh Elser <el...@apache.org>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1076: PHOENIX-3710 Cannot use lowername data table name with indextool
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1076:
URL: https://github.com/apache/phoenix/pull/1076#issuecomment-758486408
Updated commons-cli to 1.4 (as in master)
changed parser implementation (to be the same as in master)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1076: PHOENIX-3710 Cannot use lowername data table name with indextool
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1076:
URL: https://github.com/apache/phoenix/pull/1076#issuecomment-758621768
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 4m 30s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 41s | 4.x passed |
| +1 :green_heart: | compile | 1m 31s | 4.x passed |
| +1 :green_heart: | checkstyle | 1m 3s | 4.x passed |
| +1 :green_heart: | javadoc | 1m 54s | 4.x passed |
| +0 :ok: | spotbugs | 4m 12s | root in 4.x has 999 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 2m 47s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 49s | the patch passed |
| +1 :green_heart: | compile | 1m 31s | the patch passed |
| +1 :green_heart: | javac | 1m 31s | the patch passed |
| -1 :x: | checkstyle | 1m 4s | root: The patch generated 43 new + 1308 unchanged - 34 fixed = 1351 total (was 1342) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 1m 57s | the patch passed |
| +1 :green_heart: | spotbugs | 7m 33s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 147m 25s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 23s | The patch does not generate ASF License warnings. |
| | | 193m 37s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1076/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1076 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml |
| uname | Linux 70d03b943ea9 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / f1df239 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1076/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1076/3/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1076/3/testReport/ |
| Max. process+thread count | 5743 (vs. ulimit of 30000) |
| modules | C: phoenix-core . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1076/3/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] joshelser commented on pull request #1076: PHOENIX-3710 Cannot use lowername data table name with indextool
Posted by GitBox <gi...@apache.org>.
joshelser commented on pull request #1076:
URL: https://github.com/apache/phoenix/pull/1076#issuecomment-756844475
```
[ERROR] Tests run: 75, Failures: 0, Errors: 15, Skipped: 0, Time elapsed: 371.697 s <<< FAILURE! - in org.apache.phoenix.end2end.IndexToolIT
[ERROR] testCaseSensitiveNames[transactionProvider=TEPHRA,mutable=false,localIndex=false,directApi=true,useSnapshot=false,useTenant=false](org.apache.phoenix.end2end.IndexToolIT) Time elapsed: 16.924 s <<< ERROR!
java.lang.NullPointerException
at org.apache.phoenix.end2end.IndexToolIT.verifyMapper(IndexToolIT.java:931)
at org.apache.phoenix.end2end.IndexToolIT.runIndexTool(IndexToolIT.java:973)
at org.apache.phoenix.end2end.IndexToolIT.runIndexTool(IndexToolIT.java:953)
at org.apache.phoenix.end2end.IndexToolIT.runIndexTool(IndexToolIT.java:944)
at org.apache.phoenix.end2end.IndexToolIT.runIndexTool(IndexToolIT.java:938)
at org.apache.phoenix.end2end.IndexToolIT.runIndexTool(IndexToolIT.java:911)
at org.apache.phoenix.end2end.IndexToolIT.testCaseSensitiveNames(IndexToolIT.java:743)
```
Looks like a valid test failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1076: PHOENIX-3710 Cannot use lowername data table name with indextool
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1076:
URL: https://github.com/apache/phoenix/pull/1076#issuecomment-756264098
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 5m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 13m 44s | 4.x passed |
| +1 :green_heart: | compile | 1m 1s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 59s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 45s | 4.x passed |
| +0 :ok: | spotbugs | 2m 53s | phoenix-core in 4.x has 961 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 43s | the patch passed |
| +1 :green_heart: | compile | 0m 59s | the patch passed |
| +1 :green_heart: | javac | 0m 59s | the patch passed |
| -1 :x: | checkstyle | 1m 0s | phoenix-core: The patch generated 40 new + 1292 unchanged - 31 fixed = 1332 total (was 1323) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 45s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 7s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 133m 8s | phoenix-core in the patch failed. |
| -1 :x: | asflicense | 0m 50s | The patch generated 1 ASF License warnings. |
| | | 173m 19s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.IndexToolIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1076/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1076 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 5d370d4e7004 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 43b56d4 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1076/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1076/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1076/1/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1076/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 5902 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1076/1/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1076: PHOENIX-3710 Cannot use lowername data table name with indextool
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1076:
URL: https://github.com/apache/phoenix/pull/1076#issuecomment-756905276
> Looks like a valid test failure.
I always falsely hope that the backport won't introduce problems. Sorry for not noticing this before pinging you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1076: PHOENIX-3710 Cannot use lowername data table name with indextool
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1076:
URL: https://github.com/apache/phoenix/pull/1076#issuecomment-756905276
> Looks like a valid test failure.
I always falsely hope that the backport won't introduce problems. Sorry for not noticing this before pinging you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty closed pull request #1076: PHOENIX-3710 Cannot use lowername data table name with indextool
Posted by GitBox <gi...@apache.org>.
stoty closed pull request #1076:
URL: https://github.com/apache/phoenix/pull/1076
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] joshelser commented on pull request #1076: PHOENIX-3710 Cannot use lowername data table name with indextool
Posted by GitBox <gi...@apache.org>.
joshelser commented on pull request #1076:
URL: https://github.com/apache/phoenix/pull/1076#issuecomment-756844475
```
[ERROR] Tests run: 75, Failures: 0, Errors: 15, Skipped: 0, Time elapsed: 371.697 s <<< FAILURE! - in org.apache.phoenix.end2end.IndexToolIT
[ERROR] testCaseSensitiveNames[transactionProvider=TEPHRA,mutable=false,localIndex=false,directApi=true,useSnapshot=false,useTenant=false](org.apache.phoenix.end2end.IndexToolIT) Time elapsed: 16.924 s <<< ERROR!
java.lang.NullPointerException
at org.apache.phoenix.end2end.IndexToolIT.verifyMapper(IndexToolIT.java:931)
at org.apache.phoenix.end2end.IndexToolIT.runIndexTool(IndexToolIT.java:973)
at org.apache.phoenix.end2end.IndexToolIT.runIndexTool(IndexToolIT.java:953)
at org.apache.phoenix.end2end.IndexToolIT.runIndexTool(IndexToolIT.java:944)
at org.apache.phoenix.end2end.IndexToolIT.runIndexTool(IndexToolIT.java:938)
at org.apache.phoenix.end2end.IndexToolIT.runIndexTool(IndexToolIT.java:911)
at org.apache.phoenix.end2end.IndexToolIT.testCaseSensitiveNames(IndexToolIT.java:743)
```
Looks like a valid test failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1076: PHOENIX-3710 Cannot use lowername data table name with indextool
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1076:
URL: https://github.com/apache/phoenix/pull/1076#issuecomment-758653787
Can you check this again @joshelser ?
The tests are clean.
The shading failures are an unrealted issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org