You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/06/17 17:57:28 UTC
[kudu-CR] [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21523
Change subject: [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN
......................................................................
[client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN
Change-Id: I1f5ce6d46260d038bf11d1972c7f7299473ab324
---
M src/kudu/client/client-test.cc
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/21523/1
--
To view, visit http://gerrit.cloudera.org:8080/21523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f5ce6d46260d038bf11d1972c7f7299473ab324
Gerrit-Change-Number: 21523
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21523 )
Change subject: [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21523/1/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
http://gerrit.cloudera.org:8080/#/c/21523/1/src/kudu/client/client-test.cc@2449
PS1, Line 2449: 100
Any specific reasoning behind arriving at this value?
--
To view, visit http://gerrit.cloudera.org:8080/21523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f5ce6d46260d038bf11d1972c7f7299473ab324
Gerrit-Change-Number: 21523
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 17 Jun 2024 18:35:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21523 )
Change subject: [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN
......................................................................
Patch Set 1: Verified+1
unrelated Java test failures (TSAN)
--
To view, visit http://gerrit.cloudera.org:8080/21523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f5ce6d46260d038bf11d1972c7f7299473ab324
Gerrit-Change-Number: 21523
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 17 Jun 2024 19:41:28 +0000
Gerrit-HasComments: No
[kudu-CR] [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21523 )
Change subject: [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21523/1/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
http://gerrit.cloudera.org:8080/#/c/21523/1/src/kudu/client/client-test.cc@2449
PS1, Line 2449: 100
> Any specific reasoning behind arriving at this value?
Just usual consideration: this is to be at least order of magnitude less than the values in non-sanitized builds, but allow for several resets during the runtime of the test (1 second).
--
To view, visit http://gerrit.cloudera.org:8080/21523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f5ce6d46260d038bf11d1972c7f7299473ab324
Gerrit-Change-Number: 21523
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 17 Jun 2024 18:40:54 +0000
Gerrit-HasComments: Yes
[kudu-CR] [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/21523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I1f5ce6d46260d038bf11d1972c7f7299473ab324
Gerrit-Change-Number: 21523
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21523 )
Change subject: [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21523/1/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
http://gerrit.cloudera.org:8080/#/c/21523/1/src/kudu/client/client-test.cc@2449
PS1, Line 2449: 100
> Just usual consideration: this is to be at least order of magnitude less th
Thanks for the clarification.
--
To view, visit http://gerrit.cloudera.org:8080/21523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f5ce6d46260d038bf11d1972c7f7299473ab324
Gerrit-Change-Number: 21523
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 17 Jun 2024 18:41:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21523 )
Change subject: [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/248/
--
To view, visit http://gerrit.cloudera.org:8080/21523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f5ce6d46260d038bf11d1972c7f7299473ab324
Gerrit-Change-Number: 21523
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 17 Jun 2024 17:57:34 +0000
Gerrit-HasComments: No
[kudu-CR] [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21523 )
Change subject: [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/248/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f5ce6d46260d038bf11d1972c7f7299473ab324
Gerrit-Change-Number: 21523
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 17 Jun 2024 19:27:37 +0000
Gerrit-HasComments: No
[kudu-CR] [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21523 )
Change subject: [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN
......................................................................
[client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN
Change-Id: I1f5ce6d46260d038bf11d1972c7f7299473ab324
Reviewed-on: http://gerrit.cloudera.org:8080/21523
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/client/client-test.cc
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/21523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f5ce6d46260d038bf11d1972c7f7299473ab324
Gerrit-Change-Number: 21523
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>