You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Sorin Suciu (JIRA)" <qp...@incubator.apache.org> on 2010/06/21 16:08:23 UTC
[jira] Created: (QPID-2678) Qpid Shutdown OSGI plugin
Qpid Shutdown OSGI plugin
-------------------------
Key: QPID-2678
URL: https://issues.apache.org/jira/browse/QPID-2678
Project: Qpid
Issue Type: Improvement
Components: Java Broker
Affects Versions: 0.7
Reporter: Sorin Suciu
Priority: Minor
Fix For: 0.7
Having an OSGI plugin that would shutdown the broker via a JMX command (other possibilities would be listening to a port or to a certain queue) could be useful at least for testing purposes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2678) Qpid Shutdown OSGI plugin
Posted by "Sorin Suciu (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894549#action_12894549 ]
Sorin Suciu commented on QPID-2678:
-----------------------------------
Thanks for the comments Robbie, I will look to address them.
> Qpid Shutdown OSGI plugin
> -------------------------
>
> Key: QPID-2678
> URL: https://issues.apache.org/jira/browse/QPID-2678
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Affects Versions: 0.7
> Reporter: Sorin Suciu
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-QPI-2678-Broker-Shutdown-OSGI-Plugin-initial-version.patch
>
>
> Having an OSGI plugin that would shutdown the broker via a JMX command (other possibilities would be listening to a port or to a certain queue) could be useful at least for testing purposes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Assigned: (QPID-2678) Qpid Shutdown OSGI plugin
Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell reassigned QPID-2678:
------------------------------------
Assignee: Robbie Gemmell
> Qpid Shutdown OSGI plugin
> -------------------------
>
> Key: QPID-2678
> URL: https://issues.apache.org/jira/browse/QPID-2678
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Affects Versions: 0.7
> Reporter: Sorin Suciu
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-QPI-2678-Broker-Shutdown-OSGI-Plugin-initial-version.patch
>
>
> Having an OSGI plugin that would shutdown the broker via a JMX command (other possibilities would be listening to a port or to a certain queue) could be useful at least for testing purposes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2678) Qpid Shutdown OSGI plugin
Posted by "Sorin Suciu (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sorin Suciu updated QPID-2678:
------------------------------
Attachment: 0001-QPI-2678-Broker-Shutdown-OSGI-Plugin-initial-version.patch
An Initial version, tests coming...
> Qpid Shutdown OSGI plugin
> -------------------------
>
> Key: QPID-2678
> URL: https://issues.apache.org/jira/browse/QPID-2678
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Affects Versions: 0.7
> Reporter: Sorin Suciu
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-QPI-2678-Broker-Shutdown-OSGI-Plugin-initial-version.patch
>
>
> Having an OSGI plugin that would shutdown the broker via a JMX command (other possibilities would be listening to a port or to a certain queue) could be useful at least for testing purposes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2678) Qpid Shutdown OSGI plugin
Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906367#action_12906367 ]
Robbie Gemmell commented on QPID-2678:
--------------------------------------
The Activator class is no longer properly formatted, and still contains System.out logging.
The Manifest should probably lose these newly added lines:
+Ant-Version: Apache Ant 1.7.1
+Created-By: 16.3-b01-279 (Apple Inc.)
> Qpid Shutdown OSGI plugin
> -------------------------
>
> Key: QPID-2678
> URL: https://issues.apache.org/jira/browse/QPID-2678
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Affects Versions: 0.7
> Reporter: Sorin Suciu
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-QPI-2678-Broker-Shutdown-OSGI-Plugin-initial-version.patch, qpid-2678.patch
>
>
> Having an OSGI plugin that would shutdown the broker via a JMX command (other possibilities would be listening to a port or to a certain queue) could be useful at least for testing purposes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2678) Qpid Shutdown OSGI plugin
Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894396#action_12894396 ]
Robbie Gemmell commented on QPID-2678:
--------------------------------------
The use of system.out.println() should be removed.
Why make a new ScheduledThreadPoolExecutor at every call of the shutdown(delay) method? I would change it to an instance variable I think. Also, given that it is simply going to shut down the JVM when it runs the first scheduled task it probably only needs 1 thread instead of 3.
It doesnt seem like the build.xml file should be overriding the bundle task? There is no .bnd file to be processed for the module and there is a specific manifest provided anyway.
> Qpid Shutdown OSGI plugin
> -------------------------
>
> Key: QPID-2678
> URL: https://issues.apache.org/jira/browse/QPID-2678
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Affects Versions: 0.7
> Reporter: Sorin Suciu
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-QPI-2678-Broker-Shutdown-OSGI-Plugin-initial-version.patch
>
>
> Having an OSGI plugin that would shutdown the broker via a JMX command (other possibilities would be listening to a port or to a certain queue) could be useful at least for testing purposes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2678) Qpid Shutdown OSGI plugin
Posted by "Sorin Suciu (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sorin Suciu updated QPID-2678:
------------------------------
Attachment: qpid-2678.patch
Issues pointed by Robbie were addressed.
> Qpid Shutdown OSGI plugin
> -------------------------
>
> Key: QPID-2678
> URL: https://issues.apache.org/jira/browse/QPID-2678
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Affects Versions: 0.7
> Reporter: Sorin Suciu
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.7
>
> Attachments: 0001-QPI-2678-Broker-Shutdown-OSGI-Plugin-initial-version.patch, qpid-2678.patch
>
>
> Having an OSGI plugin that would shutdown the broker via a JMX command (other possibilities would be listening to a port or to a certain queue) could be useful at least for testing purposes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org