[jira] [Commented] (THRIFT-2027) Minor 64-bit and NOMINMAX issues in C++ library

["Jens Geyer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790746#comment-13790746 ] 

Jens Geyer commented on THRIFT-2027:
------------------------------------

+1

{quote}
It's 2013, and the world is still dealing with EOL conflicts.
{quote}

Full ACK. There are a lot of things that should have been solved already, years ago. This is one of them.

> Minor 64-bit and NOMINMAX issues in C++ library
> -----------------------------------------------
>
>                 Key: THRIFT-2027
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2027
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9
>         Environment: 64-bit.  Windows without NOMINMAX set.
>            Reporter: Ben Craig
>            Assignee: Ben Craig
>            Priority: Minor
>             Fix For: 1.0
>
>         Attachments: misc_minor.patch
>
>
> TNonblockingServer and THttpServer have size_t -> uint32_t truncations.
> TZlibTransport calls std::min without enclosing it in parens.  This is a really minor issue, since we technically build with NOMINMAX in the environment (which fixes the problem), but I have a strange personal goal of being able to build without setting NOMINMAX.



--
This message was sent by Atlassian JIRA
(v6.1#6144)