[GitHub] [solr] epugh commented on pull request #43: SOLR-15278: allow the flush parameter to be passed when doing a DELETE

[GitBox <gi...@apache.org>]

epugh commented on pull request #43:
URL: https://github.com/apache/solr/pull/43#issuecomment-805732288


   I am definitly not anchored to this approach...   However, I just want to clarify that this is a brand NEW end point, that never existed before.    There are two types of DELETE's now used:
   
   The original single item, similar to V1:
   
   ```
   curl -X DELETE http://localhost:8983/api/cluster/command-status/1000
   ```
   and then what I am proposing which is to delete all completed/error responses:
   
   ```
   curl -X DELETE http://localhost:8983/api/cluster/command-status
   ```
   
   I want to mimic other RESTful approaches, so I looked at https://learn.co/lessons/rails-intro-to-rest, and it doesn't really appear that a DELETE is ever run on a whole category of items.   It's always one item at a time.   Which I guess does make sense....   How often do you want to dlete everythign!
   
   So. what are thoughts on
   
   ```
   curl -X DELETE http://localhost:8983/api/cluster/command-status?flush=true
   ```
   
   I could do 
   ```
   curl -X DELETE http://localhost:8983/api/cluster/command-status/state/flush
   ```
   
   as well..     
   
   Poking about, I see advice that would suggest that you create new resources/end points:
   
   ```
   POST /api/path/to/your/collection:batchDelete
   ```
   
   So for us it would be:
   ```
   curl -X POST  http://localhost:8983/api/cluster/command-status:flush
   ```
   
   The `:flush` syntax would be a new concept in our urls....
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org