[jira] [Created] (OODT-950) Condition that compares the same expression

["JC (JIRA)" <ji...@apache.org>]

JC created OODT-950:
-----------------------

             Summary: Condition that compares the same expression
                 Key: OODT-950
                 URL: https://issues.apache.org/jira/browse/OODT-950
             Project: OODT
          Issue Type: Bug
            Reporter: JC


Hi

In a recent Github mirror, I've found the following suspicious code in pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/FileRetrievalSystem.java

{code}
662     Protocol modifyAvailableSessionForPath(RemoteSiteFile file)
663             throws RemoteConnectionException {
664         Protocol session = getAvailableSession();
665         if (!file.getSite().getURL().getHost().equals(
666                 file.getSite().getURL().getHost())
667                 || !protocolHandler.isProtocolConnected(session)) {
668             protocolHandler.disconnect(session);
669             session = protocolHandler.getAppropriateProtocol(file, /* reuse */
670             false, /* navigate */true);
671         } else {
{code}

In Line 665 and 666, equals compares the same expression. This may not be an issue but wanted to report just in case. Thanks!



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)