You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "123123213weqw (via GitHub)" <gi...@apache.org> on 2026/08/21 08:08:34 UTC

[I] [Studio][Bug] Scope recent message queries by instance [rocketmq-dashboard]

123123213weqw opened a new issue, #2503:
URL: https://github.com/apache/rocketmq-dashboard/issues/2503

   ## Problem
   
   Recent queries use a global localStorage key and the dedupe signature does not include the instance. After switching instances, replaying an old query runs against the current instance with no indication of the original one.
   
   Location: `web/src/pages/instance/message.tsx`.
   
   ## Expected behavior
   
   Store instanceId in RecentQuery and include it in the signature; either show only the current instance's records, or display the instance explicitly and switch to it on replay.
   
   ## Verification
   
   Two instances querying the same Topic/Key do not overwrite each other; legacy-format records migrate or are ignored safely.
   
   Note: PR #767 only added the recent-query feature; multi-instance isolation was never addressed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Studio][Bug] Scope recent message queries by instance [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #2503:
URL: https://github.com/apache/rocketmq-dashboard/issues/2503#issuecomment-5459081636

   This issue has been automatically closed because there has been no activity for 7 days. If you believe this issue is still relevant, please reopen it with updated information.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Studio][Bug] Scope recent message queries by instance [rocketmq-dashboard]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #2503:
URL: https://github.com/apache/rocketmq-dashboard/issues/2503#issuecomment-5367863567

   **Issue Evaluation**
   
   Category: `bug` | Status: **Confirmed**
   
   The reported issue is valid. The recent queries feature in `web/src/pages/instance/message.tsx` uses a global localStorage key without instance scoping. When users switch instances, replaying a previous query silently targets the current instance with no visual indication of the original context.
   
   **Root Cause:** RecentQuery storage and deduplication signature do not include `instanceId`.
   **Impact:** Users working with multiple instances may unknowingly execute queries against the wrong instance.
   **Severity:** medium
   
   An automated fix proposal can be generated. Reply `/approve` to proceed with PR generation.
   
   ---
   *Automated evaluation by github-manager*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Studio][Bug] Scope recent message queries by instance [rocketmq-dashboard]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #2503:
URL: https://github.com/apache/rocketmq-dashboard/issues/2503#issuecomment-5370403053

   Hi @123123213weqw, thanks for reporting this!
   
   I've analyzed this issue against the codebase and can confirm this appears to be a **real bug**.
   
   **Root Cause:** ** The `RecentQuery` type (line 73-76) stores only `{ mode, params }` with no `instanceId`. The localStorage key `QUERY_HISTORY_STORAGE_KEY` (line 87) is a single global string, and `querySignature` (line 218) dedupes only on `mode` + `params`. When switching instances, `replayRecentQuery` (line 401) runs the old query against the current instance with no awareness of the original instance.
   **Affected Files:** ** web/src/pages/instance/message.tsx
   
   **Analysis:** ** Three compounding issues:
   
   I'll prepare a fix spec and work on a PR. The community is welcome to provide feedback on the approach before implementation.
   
   ---
   🤖 *Automated issue analysis by github-manager*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Studio][Bug] Scope recent message queries by instance [rocketmq-dashboard]

Posted by "123123213weqw (via GitHub)" <gi...@apache.org>.
123123213weqw commented on issue #2503:
URL: https://github.com/apache/rocketmq-dashboard/issues/2503#issuecomment-5367152184

   Picking this one up, PR coming shortly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Studio][Bug] Scope recent message queries by instance [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #2503: [Studio][Bug] Scope recent message queries by instance
URL: https://github.com/apache/rocketmq-dashboard/issues/2503


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org