You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/22 05:14:28 UTC

[GitHub] [pulsar] lhotari commented on a diff in pull request #13740: [improve][broker-web&websocket&proxy&function-worker] Full-support set ssl provider, ciphers and protocols

lhotari commented on code in PR #13740:
URL: https://github.com/apache/pulsar/pull/13740#discussion_r855772044


##########
pulsar-common/src/main/java/org/apache/pulsar/common/util/SecurityUtility.java:
##########
@@ -115,7 +114,7 @@ public static Provider getProvider() {
         }
     }
 
-    private static Provider loadConscryptProvider() {
+    public static Provider loadConscryptProvider() {

Review Comment:
   this shouldn't be exposed. This method is meant to be called exactly once. Instead, `if(SecurityUtility.CONSCRYPT_PROVIDER != null) {` could be used in some other class to see if Conscrypt is available. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org