You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "linghengqian (via GitHub)" <gi...@apache.org> on 2024/11/15 16:08:17 UTC

[PR] Avoid using `-proc:full` when compiling ShardingSphere with OpenJDK23 [shardingsphere]

linghengqian opened a new pull request, #33681:
URL: https://github.com/apache/shardingsphere/pull/33681

   For #32927.
   
   Changes proposed in this pull request:
     - Avoid using `-proc:full` when compiling ShardingSphere with OpenJDK23. This is mostly to align the behavior of https://github.com/apache/shardingsphere-elasticjob/pull/2454. Changing the default value of `-proc` on JDK23 is probably not a good idea.
     - Since `org.apache.shardingsphere.sqlfederation.optimizer.planner.rule.transformation.PushProjectIntoScanRule` is generating **`org.apache.shardingsphere.sqlfederation.optimizer.planner.rule.transformation.ImmutablePushProjectIntoScanRule`** through `org.immutables.processor.ProxyProcessor`, the scope of `annotationProcessorPaths` is quite scattered. See https://github.com/immutables/immutables/issues/713 .
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [x] I have self-reviewed the commit code.
   - [x] I have (or in comment I request) added corresponding labels for the pull request.
   - [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [x] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   - [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Avoid using `-proc:full` when compiling ShardingSphere with OpenJDK23 [shardingsphere]

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #33681:
URL: https://github.com/apache/shardingsphere/pull/33681


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org