[GitHub] [pulsar-dotpulsar] usaguerrilla commented on a change in pull request #48: Producer for Partitioned topics

[GitBox <gi...@apache.org>]

usaguerrilla commented on a change in pull request #48:
URL: https://github.com/apache/pulsar-dotpulsar/pull/48#discussion_r466759246



##########
File path: src/DotPulsar/Internal/PartitionedProducer.cs
##########
@@ -0,0 +1,244 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+namespace DotPulsar.Internal
+{
+    using DotPulsar.Abstractions;
+    using DotPulsar.Internal.Abstractions;
+    using System;
+    using System.Buffers;
+    using System.Collections.Concurrent;
+    using System.Collections.Generic;
+    using System.Threading;
+    using System.Threading.Tasks;
+
+    public sealed class PartitionedProducer : IProducer
+    {
+        private readonly ConcurrentDictionary<int, IProducer> _producers;
+        private readonly StateManager<ProducerState> _state;
+        private PartitionedTopicMetadata _partitionedTopicMetadata;
+        private int _isDisposed;
+        private ConcurrentBag<Task> _monitorStateTask;

Review comment:
       we keep adding tasks to this bah, who takes them out?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org