You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "swamirishi (via GitHub)" <gi...@apache.org> on 2025/06/06 10:27:26 UTC
Re: [PR] HDDS-13114. MaxCompactionBytes and MaxSubCompactions should be configureable in RDBStore#compactTable [ozone]
swamirishi commented on code in PR #8572:
URL: https://github.com/apache/ozone/pull/8572#discussion_r2131941109
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/DBStoreBuilder.java:
##########
@@ -223,7 +224,10 @@ public RDBStore build() throws IOException {
throw new IOException("The DB destination directory should exist.");
}
- return new RDBStore(dbFile, rocksDBOption, statistics, writeOptions, tableConfigs,
+ ManagedCompactRangeOptions rangeCompactionOptions = new ManagedCompactRangeOptions();
Review Comment:
This shouldn't be done on the automatic background compactions. We need these compaction options only for the manual compactions done by the BackgroundCompactionService & SnapshotCache. These default options on the rocksdb options should be coming from an ini file we don't want individual ozone configuration corresponding to each and every rocksdb configuration this might get very tough to handle later.
https://issues.apache.org/jira/browse/HDDS-12484
cc: @Galsza
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/DBStoreBuilder.java:
##########
@@ -223,7 +224,10 @@ public RDBStore build() throws IOException {
throw new IOException("The DB destination directory should exist.");
}
- return new RDBStore(dbFile, rocksDBOption, statistics, writeOptions, tableConfigs,
+ ManagedCompactRangeOptions rangeCompactionOptions = new ManagedCompactRangeOptions();
Review Comment:
https://github.com/apache/ozone/blob/b91e8e732f07e220b1be6b64fb74a8d3f67dbf3c/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/CompactionService.java#L140
https://github.com/apache/ozone/blob/006e691245d98e65b712cf82b8ad4f199b673431/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStore.java#L227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org