You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "benwtrent (via GitHub)" <gi...@apache.org> on 2025/12/08 15:56:59 UTC

[I] testGraphMergeWithDeletes fails [lucene]

benwtrent opened a new issue, #15485:
URL: https://github.com/apache/lucene/issues/15485

   ### Description
   
   ```
   TestHnswFloatVectorGraph > testGraphMergeWithDeletes FAILED
       java.lang.NullPointerException: Cannot read the array length because "firstNonNull" is null
           at __randomizedtesting.SeedInfo.seed([C205C09E95E3ED87:149F74FCDC9185BB]:0)
           at org.apache.lucene.util.hnsw.MockVectorValues.fromValues(MockVectorValues.java:37)
           at org.apache.lucene.util.hnsw.TestHnswFloatVectorGraph.vectorValues(TestHnswFloatVectorGraph.java:63)
           at org.apache.lucene.util.hnsw.TestHnswFloatVectorGraph.vectorValues(TestHnswFloatVectorGraph.java:39)
           at org.apache.lucene.util.hnsw.HnswGraphTestCase.testGraphMergeWithDeletes(HnswGraphTestCase.java:221)
           at org.apache.lucene.util.hnsw.TestHnswFloatVectorGraph.testGraphMergeWithDeletes(TestHnswFloatVectorGraph.java:39)
           at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
           at java.base/java.lang.reflect.Method.invoke(Method.java:565)
   ```
   
   ### Gradle command to reproduce
   
   ```
   ./gradlew test --tests TestHnswFloatVectorGraph.testGraphMergeWithDeletes -Dtests.seed=C205C09E95E3ED87 -Dtests.locale=az-AZ -Dtests.timezone=Asia/Harbin -Dtests.asserts=true -Dtests.file.encoding=UTF-8
   ```
   
   I suspect is due to the connection things...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [I] testGraphMergeWithDeletes fails [lucene]

Posted by "benwtrent (via GitHub)" <gi...@apache.org>.
benwtrent closed issue #15485: testGraphMergeWithDeletes fails
URL: https://github.com/apache/lucene/issues/15485


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [I] testGraphMergeWithDeletes fails [lucene]

Posted by "benwtrent (via GitHub)" <gi...@apache.org>.
benwtrent commented on issue #15485:
URL: https://github.com/apache/lucene/issues/15485#issuecomment-3627918328

   @Pulkitg64 quick find! Indeed, that looks suspect :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [I] testGraphMergeWithDeletes fails [lucene]

Posted by "benwtrent (via GitHub)" <gi...@apache.org>.
benwtrent commented on issue #15485:
URL: https://github.com/apache/lucene/issues/15485#issuecomment-3627768946

   commit ef10476d98ab37b92fe48a1f71a1a06dad009ae3
   Author: Pulkit Gupta <36...@users.noreply.github.com>
   Date:   Tue Dec 2 03:44:21 2025 +0530
   
       Avoid reconstructing HNSW graphs during segment merging. (#15003)
   
       optimizes HNSW graph merging. Now instead of not considering a large graph to merge into, deleted nodes are removed and the related connections are repaired. Additionally, nodes might be promoted to higher levels to account for loss of connectivity at higher layers.
   
       Especially in singleton merges, this improves throughput significantly.
   
   
   Indeed, gitbisect indicates this. Though, I think it might just be because this test was added with this PR ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [I] testGraphMergeWithDeletes fails [lucene]

Posted by "Pulkitg64 (via GitHub)" <gi...@apache.org>.
Pulkitg64 commented on issue #15485:
URL: https://github.com/apache/lucene/issues/15485#issuecomment-3627795967

   Thank @benwtrent for catching this and sorry for the issue. I think the issue is with this line in the test:
   
   ```
   int numVectors = random().nextInt(1000);
   ```
   
   For this seed, numVectors is zero hence we are getting that exception, I think just tweaking the test to have minimum 1 vector should fix the issue.
   
   Raising fix for this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org