You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by "afs (via GitHub)" <gi...@apache.org> on 2023/04/27 07:13:41 UTC
[GitHub] [jena] afs opened a new pull request, #1853: Cleanup
afs opened a new pull request, #1853:
URL: https://github.com/apache/jena/pull/1853
Post release cleanup.
The test related changes should stabilize using GH actionswher there seems to be timing interactions related to cleaning up earlier tests. These occur on GH actions predicatably, some infrequently ASF Jenkins, but not locally nor when test are run in isolation.
----
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on a diff in pull request #1853: Cleanup
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on code in PR #1853:
URL: https://github.com/apache/jena/pull/1853#discussion_r1178816893
##########
jena-fuseki2/jena-fuseki-geosparql/src/test/java/org/apache/jena/fuseki/geosparql/EmptyTest.java:
##########
@@ -59,6 +65,7 @@ public static void setUpClass() throws DatasetException, SpatialIndexException {
//Configure server
SERVER = new GeosparqlServer(argsConfig.getPort(), argsConfig.getDatsetName(), argsConfig.isLoopbackOnly(), dataset, argsConfig.isUpdateAllowed());
SERVER.start();
+ Lib.sleep(1000);
Review Comment:
Is this sleep here necessary? It looks like something that could still fail if, for instance, it took 1.5 seconds on some other hardware or environment.
Other tests are calling the `Helper#run`, which also uses this `Lib#sleep` method, but in a better way, I think. So maybe these other calls to `Lib#sleep` could be removed? And I think this might be fixing some tests, but other tests were still commented out any way as they were still brittle on GH Actions, so maybe there will be a better fix (or we could leave `TODO` markers next to this code until someone has time to improve the tests?),
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a diff in pull request #1853: Cleanup
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on code in PR #1853:
URL: https://github.com/apache/jena/pull/1853#discussion_r1178953952
##########
jena-fuseki2/jena-fuseki-geosparql/src/test/java/org/apache/jena/fuseki/geosparql/EmptyTest.java:
##########
@@ -59,6 +65,7 @@ public static void setUpClass() throws DatasetException, SpatialIndexException {
//Configure server
SERVER = new GeosparqlServer(argsConfig.getPort(), argsConfig.getDatsetName(), argsConfig.isLoopbackOnly(), dataset, argsConfig.isUpdateAllowed());
SERVER.start();
+ Lib.sleep(1000);
Review Comment:
OK - I'll try. The server start "Lib.sleep" are more for giving the server thread a chance to run (probably don't to be 1000ms - the length isn't so important as the fact the current thread pauses. `Helper#run` is still necessary.
... there'll be some commits so I can run the GH actions on my account.
(Also added a commit to add comments `DoubleNode62` - unrelated!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #1853: Cleanup
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs merged PR #1853:
URL: https://github.com/apache/jena/pull/1853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on a diff in pull request #1853: Cleanup
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on code in PR #1853:
URL: https://github.com/apache/jena/pull/1853#discussion_r1179577868
##########
jena-tdb2/src/main/java/org/apache/jena/tdb2/store/value/DoubleNode62.java:
##########
@@ -235,7 +235,7 @@ else if ( exp9 == 0x1FF )
* 0x01L
* @see Double#MIN_VALUE
*/
- public static final double MIN_VALUE = unpack(MIN_VALUE_BITS);
+ public static final double MIN_VALUE = unpack(MIN_VALUE_BITS); // 4.9e-324
Review Comment:
:ok_hand:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1853: Cleanup
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #1853:
URL: https://github.com/apache/jena/pull/1853#issuecomment-1526671234
fuseki-geosparql tests fixed.
The cause was (probably!) that the geosparql server was a thread that started Fuseki, and Fusek starts Jetty threads. A thread starting threads. It does not need to. The double threading made shutdown unreliable (used a thread shutdown action) and is susceptible to the unpredictable (weird) pauses of VM threads when the host is "well utilized" (= heavily loaded).
Actions on all 3 architectures have run successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org