[GitHub] [superset] ktmud commented on a diff in pull request #20703: refactor(test): add login_as_admin to global conftest

[GitBox <gi...@apache.org>]

ktmud commented on code in PR #20703:
URL: https://github.com/apache/superset/pull/20703#discussion_r921479080


##########
superset/views/core.py:
##########
@@ -1979,6 +1979,8 @@ def dashboard(
         return self.render_template(
             "superset/spa.html",
             entry="spa",
+            # dashboard title is always visible
+            title=dashboard.dashboard_title,

Review Comment:
   The test case [`test_get_dashboard`](https://github.com/apache/superset/pull/20703/files#diff-3f2a02719b7e0794608e6f8f1a242ec1cfcebf7e17ebf3dfea7bb664415295ff) actually tests dashboard title in the HTML, but the spa doesn't output it anymore. I'm not sure why current `master` passes the CI. It throws a test error, too, when running locally on my machine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org