You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Kevin Sweeney <ke...@apache.org> on 2014/12/20 04:05:06 UTC
Review Request 29286: Fix BUILD files in apache.aurora.admin and
apache.aurora.client.api.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29286/
-----------------------------------------------------------
Review request for Aurora and Brian Wickman.
Repository: aurora
Description
-------
Fix BUILD files in apache.aurora.admin and apache.aurora.client.api.
Diffs
-----
src/main/python/apache/aurora/admin/BUILD f874264bdf07a9cbb2f0990739be3c95f851b040
src/main/python/apache/aurora/admin/host_maintenance.py 8fa5182fae509493def7175635fbe1cb79fa3eec
src/main/python/apache/aurora/client/api/BUILD 65e5a85e23c4c698356c8b45c45943e560c1bcd5
src/main/python/apache/aurora/client/api/command_runner.py 48cb567c2098620e0ee322fe9528e167ce7c7c62
src/main/python/apache/aurora/client/api/disambiguator.py 6a78ccd44533ef327f751a08c9e2e16555354d97
src/test/python/apache/aurora/admin/BUILD 3a216809d1e31247f7d01451fcc7fd877a4c1fb2
src/test/python/apache/aurora/client/api/BUILD 2c0c4070cc1f1784b1d4e7f9cd8aac236e97be75
src/test/python/apache/aurora/client/api/test_task_util.py 048aff6874259810efea463df1ca2a1fdc419ca1
Diff: https://reviews.apache.org/r/29286/diff/
Testing
-------
./pants src/test/python:all
Thanks,
Kevin Sweeney
Re: Review Request 29286: Fix BUILD files in apache.aurora.admin and
apache.aurora.client.api.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29286/#review65729
-----------------------------------------------------------
Ship it!
Ship It!
- Joe Smith
On Dec. 19, 2014, 7:05 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29286/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2014, 7:05 p.m.)
>
>
> Review request for Aurora and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix BUILD files in apache.aurora.admin and apache.aurora.client.api.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD f874264bdf07a9cbb2f0990739be3c95f851b040
> src/main/python/apache/aurora/admin/host_maintenance.py 8fa5182fae509493def7175635fbe1cb79fa3eec
> src/main/python/apache/aurora/client/api/BUILD 65e5a85e23c4c698356c8b45c45943e560c1bcd5
> src/main/python/apache/aurora/client/api/command_runner.py 48cb567c2098620e0ee322fe9528e167ce7c7c62
> src/main/python/apache/aurora/client/api/disambiguator.py 6a78ccd44533ef327f751a08c9e2e16555354d97
> src/test/python/apache/aurora/admin/BUILD 3a216809d1e31247f7d01451fcc7fd877a4c1fb2
> src/test/python/apache/aurora/client/api/BUILD 2c0c4070cc1f1784b1d4e7f9cd8aac236e97be75
> src/test/python/apache/aurora/client/api/test_task_util.py 048aff6874259810efea463df1ca2a1fdc419ca1
>
> Diff: https://reviews.apache.org/r/29286/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 29286: Fix BUILD files in apache.aurora.admin and
apache.aurora.client.api.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29286/#review70093
-----------------------------------------------------------
Is this patch still relevant?
- Bill Farner
On Dec. 20, 2014, 3:05 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29286/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2014, 3:05 a.m.)
>
>
> Review request for Aurora and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix BUILD files in apache.aurora.admin and apache.aurora.client.api.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD f874264bdf07a9cbb2f0990739be3c95f851b040
> src/main/python/apache/aurora/admin/host_maintenance.py 8fa5182fae509493def7175635fbe1cb79fa3eec
> src/main/python/apache/aurora/client/api/BUILD 65e5a85e23c4c698356c8b45c45943e560c1bcd5
> src/main/python/apache/aurora/client/api/command_runner.py 48cb567c2098620e0ee322fe9528e167ce7c7c62
> src/main/python/apache/aurora/client/api/disambiguator.py 6a78ccd44533ef327f751a08c9e2e16555354d97
> src/test/python/apache/aurora/admin/BUILD 3a216809d1e31247f7d01451fcc7fd877a4c1fb2
> src/test/python/apache/aurora/client/api/BUILD 2c0c4070cc1f1784b1d4e7f9cd8aac236e97be75
> src/test/python/apache/aurora/client/api/test_task_util.py 048aff6874259810efea463df1ca2a1fdc419ca1
>
> Diff: https://reviews.apache.org/r/29286/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 29286: Fix BUILD files in apache.aurora.admin and
apache.aurora.client.api.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29286/#review70132
-----------------------------------------------------------
What specifically is taking place here? (I think I understand some of it, but I'm not sure what was broken or what is being improved.)
- Brian Wickman
On Dec. 20, 2014, 3:05 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29286/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2014, 3:05 a.m.)
>
>
> Review request for Aurora and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix BUILD files in apache.aurora.admin and apache.aurora.client.api.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD f874264bdf07a9cbb2f0990739be3c95f851b040
> src/main/python/apache/aurora/admin/host_maintenance.py 8fa5182fae509493def7175635fbe1cb79fa3eec
> src/main/python/apache/aurora/client/api/BUILD 65e5a85e23c4c698356c8b45c45943e560c1bcd5
> src/main/python/apache/aurora/client/api/command_runner.py 48cb567c2098620e0ee322fe9528e167ce7c7c62
> src/main/python/apache/aurora/client/api/disambiguator.py 6a78ccd44533ef327f751a08c9e2e16555354d97
> src/test/python/apache/aurora/admin/BUILD 3a216809d1e31247f7d01451fcc7fd877a4c1fb2
> src/test/python/apache/aurora/client/api/BUILD 2c0c4070cc1f1784b1d4e7f9cd8aac236e97be75
> src/test/python/apache/aurora/client/api/test_task_util.py 048aff6874259810efea463df1ca2a1fdc419ca1
>
> Diff: https://reviews.apache.org/r/29286/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 29286: Fix BUILD files in apache.aurora.admin and
apache.aurora.client.api.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29286/#review65725
-----------------------------------------------------------
Ship it!
Master (84ad650) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Dec. 20, 2014, 3:05 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29286/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2014, 3:05 a.m.)
>
>
> Review request for Aurora and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix BUILD files in apache.aurora.admin and apache.aurora.client.api.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD f874264bdf07a9cbb2f0990739be3c95f851b040
> src/main/python/apache/aurora/admin/host_maintenance.py 8fa5182fae509493def7175635fbe1cb79fa3eec
> src/main/python/apache/aurora/client/api/BUILD 65e5a85e23c4c698356c8b45c45943e560c1bcd5
> src/main/python/apache/aurora/client/api/command_runner.py 48cb567c2098620e0ee322fe9528e167ce7c7c62
> src/main/python/apache/aurora/client/api/disambiguator.py 6a78ccd44533ef327f751a08c9e2e16555354d97
> src/test/python/apache/aurora/admin/BUILD 3a216809d1e31247f7d01451fcc7fd877a4c1fb2
> src/test/python/apache/aurora/client/api/BUILD 2c0c4070cc1f1784b1d4e7f9cd8aac236e97be75
> src/test/python/apache/aurora/client/api/test_task_util.py 048aff6874259810efea463df1ca2a1fdc419ca1
>
> Diff: https://reviews.apache.org/r/29286/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Kevin Sweeney
>
>