You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/05/22 23:10:41 UTC

[GitHub] [systemds] mboehm7 commented on pull request #1275: Image Manipulation Primitives

mboehm7 commented on pull request #1275:
URL: https://github.com/apache/systemds/pull/1275#issuecomment-846474482


   LGTM - thanks for the patch and detailed tests @whirgod. During the merge I made a few modifications:
   
   * Removed the added but redundant hashmap-matrix conversion methods
   * Refactored the tests and resource files (in package pipelines, and expected files)
   * Fixed the expected data for the rotation test (thanks for double checking these in detail)
   * Fixed unnecessary imports and formatting issues (annotations above, not before methods)
   * Started vectorizing the parfor loop in transform (but still commented as it requires more work) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org