[GitHub] reddycharan commented on a change in pull request #1627: Fix EntryLoggerAllocator.stop

[GitBox <gi...@apache.org>]

reddycharan commented on a change in pull request #1627: Fix EntryLoggerAllocator.stop
URL: https://github.com/apache/bookkeeper/pull/1627#discussion_r213519436
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLoggerAllocator.java
 ##########
 @@ -203,6 +205,15 @@ private void setLastLogId(File dir, long logId) throws IOException {
     void stop() {
         // wait until the preallocation finished.
         allocatorExecutor.shutdown();
+        try {
+            if (!allocatorExecutor.awaitTermination(3, TimeUnit.SECONDS)) {
+                log.warn("Timedout while awaiting for allocatorExecutor's termination, so force shuttingdown");
+            }
+        } catch (InterruptedException e) {
+            log.warn("Got InterruptedException while awaiting termination of allocatorExecutor, so force shuttingdown");
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services