[jira] [Commented] (SPARK-11886) R function name conflicts with base or stats package ones

["Felix Cheung (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-11886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022787#comment-15022787 ] 

Felix Cheung commented on SPARK-11886:
--------------------------------------

We could also create a generic function to redirect the more generic calls to base:: or stats:: ones, similar to how [~sunrui] handles rank

SPARK-7499 might affect how we have method signature too.


> R function name conflicts with base or stats package ones
> ---------------------------------------------------------
>
>                 Key: SPARK-11886
>                 URL: https://issues.apache.org/jira/browse/SPARK-11886
>             Project: Spark
>          Issue Type: Bug
>          Components: SparkR
>    Affects Versions: 1.5.2
>            Reporter: Felix Cheung
>            Priority: Minor
>
> See https://github.com/apache/spark/pull/9785
> Currently these are masked:
> stats::cov
> stats::filter
> base::sample
> base::table
> [~shivaram] suggested:
> "
> If we have same name but the param types completely don't match (and no room for ...) then we override those functions but (This is true for sample, table, cov right now I guess) we should try to limit the number of functions where we do this. Also we should revisit some of these to see if we can avoid it (for example table can be renamed ?)
> "



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org