You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "MartijnVisser (via GitHub)" <gi...@apache.org> on 2026/10/21 10:22:42 UTC

[PR] [BP-1.20][FLINK-34427][tests] Wait for slot manager close() in runTest [flink]

MartijnVisser opened a new pull request, #29543:
URL: https://github.com/apache/flink/pull/29543

   Backport of https://github.com/apache/flink/pull/29533 (f2aa53456cb). Only the import block of `FineGrainedSlotManagerTestBase` differs: this branch still imports `Time`.
   
   `runTest` queues `close()` and returns without waiting for it, so `afterAll` can shut the executor down while the last test's requirements check is still running. The rejected `handleAsync` in `DefaultSlotStatusSyncer#allocateSlot` then ends the surefire fork with exit code 239. Last seen on this branch in https://github.com/apache/flink/actions/runs/39356761314/job/118426745894 (nightly 2026-10-20, `Java 11 / Test (module: core)`).
   
   On JDK 8 in a container pinned to one CPU, the class crashed in 8 of 329 runs before the change and in 0 of 1500 with the `runTest` wait. With a `requestSlot` that blocks until the executor is shut down, it crashed in 10 of 10 JVMs before the change and in 0 of 30 class runs with the `runTest` wait. The slot manager tests pass with this change on JDK 8 (118 of 118).
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code (Claude Opus 5.5, Claude Fable 5.1)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [BP-1.20][FLINK-34427][tests] Wait for slot manager close() in runTest [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #29543:
URL: https://github.com/apache/flink/pull/29543#issuecomment-6314003444

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "dc8a98735a07249baca1c4531c6fcaa9fe7cd345",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dc8a98735a07249baca1c4531c6fcaa9fe7cd345",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dc8a98735a07249baca1c4531c6fcaa9fe7cd345 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [BP-1.20][FLINK-34427][tests] Wait for slot manager close() in runTest [flink]

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser merged PR #29543:
URL: https://github.com/apache/flink/pull/29543


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org