You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (JIRA)" <ji...@apache.org> on 2018/12/20 16:37:00 UTC
[jira] [Commented] (HIVE-20859) clean up invocation of
Worker/Cleaner/Initiator in test code
[ https://issues.apache.org/jira/browse/HIVE-20859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726009#comment-16726009 ]
Hive QA commented on HIVE-20859:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 17s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 40s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 23s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 38s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 15s{color} | {color:red} itests/hive-unit: The patch generated 1 new + 148 unchanged - 21 fixed = 149 total (was 169) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m 9s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15405/dev-support/hive-personality.sh |
| git revision | master / 1020be0 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-15405/yetus/diff-checkstyle-itests_hive-unit.txt |
| modules | C: itests/hive-unit U: itests/hive-unit |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15405/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> clean up invocation of Worker/Cleaner/Initiator in test code
> ------------------------------------------------------------
>
> Key: HIVE-20859
> URL: https://issues.apache.org/jira/browse/HIVE-20859
> Project: Hive
> Issue Type: Improvement
> Components: Test, Transactions
> Affects Versions: 3.0.0
> Reporter: Eugene Koifman
> Assignee: Igor Kryvenko
> Priority: Minor
> Attachments: HIVE-20859.01.patch
>
>
> there are many places like {{CompactorTest}} that use
> {code:java|title=CompactorTest.java}
> AtomicBoolean stop = new AtomicBoolean(true);
> Worker t = new Worker();
> t.setThreadId((int) t.getId());
> t.setConf(hiveConf);
> AtomicBoolean looped = new AtomicBoolean();
> t.init(stop, looped);
> t.run();
> {code}
> should instead standardize on {{TestTxnCommands2.runWorker()}}
> same for {{Cleaner}} and {{Initiator}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)