You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/05/16 02:52:10 UTC
[GitHub] [incubator-hugegraph] wangyao2016 opened a new pull request, #1883: fix bud: get profile api cannot be accessed #1882
wangyao2016 opened a new pull request, #1883:
URL: https://github.com/apache/incubator-hugegraph/pull/1883
To solve this problem [#1882](https://github.com/apache/incubator-hugegraph/issues/1882), I modified the route of getprofile API as `/profiles`

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] wangyao2016 commented on pull request #1883: fix bug: get profile api cannot be accessed #1882
Posted by GitBox <gi...@apache.org>.
wangyao2016 commented on PR #1883:
URL: https://github.com/apache/incubator-hugegraph/pull/1883#issuecomment-1144506947
https://github.com/apache/incubator-hugegraph/pull/1893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] wangyao2016 commented on a diff in pull request #1883: fix bug: get profile api cannot be accessed #1882
Posted by GitBox <gi...@apache.org>.
wangyao2016 commented on code in PR #1883:
URL: https://github.com/apache/incubator-hugegraph/pull/1883#discussion_r873378822
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/api/profile/ProfileAPI.java:
##########
@@ -59,6 +59,7 @@ public class ProfileAPI {
private static String API_PROFILES = null;
@GET
+ @Path("profiles")
Review Comment:
It cause by this PR #1500
[this line](https://github.com/apache/incubator-hugegraph/commit/9ee9fe12f3349a54bbceb161d002200d3689863c#diff-76994bedad9c0d52982ee900de571f9db327acfd5a8ab902c606cc20dc62a19aR284)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] codecov[bot] commented on pull request #1883: fix bug: get profile api cannot be accessed #1882
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1883:
URL: https://github.com/apache/incubator-hugegraph/pull/1883#issuecomment-1127162550
# [Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1883?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1883](https://codecov.io/gh/apache/incubator-hugegraph/pull/1883?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cf17ba9) into [master](https://codecov.io/gh/apache/incubator-hugegraph/commit/f6f8c3eda68554f8eefe53322955af8216260fe1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f6f8c3e) will **decrease** coverage by `20.18%`.
> The diff coverage is `n/a`.
> :exclamation: Current head cf17ba9 differs from pull request most recent head 2e4f08a. Consider uploading reports for the commit 2e4f08a to get more accurate results
```diff
@@ Coverage Diff @@
## master #1883 +/- ##
=============================================
- Coverage 70.95% 50.77% -20.19%
+ Complexity 695 659 -36
=============================================
Files 447 449 +2
Lines 38077 38059 -18
Branches 5401 5382 -19
=============================================
- Hits 27019 19324 -7695
- Misses 8412 16612 +8200
+ Partials 2646 2123 -523
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hugegraph/pull/1883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...va/com/baidu/hugegraph/api/profile/ProfileAPI.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL3Byb2ZpbGUvUHJvZmlsZUFQSS5qYXZh) | `0.00% <ø> (ø)` | |
| [...du/hugegraph/util/FixedWatchWindowRateLimiter.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL3V0aWwvRml4ZWRXYXRjaFdpbmRvd1JhdGVMaW1pdGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...du/hugegraph/backend/store/mysql/MysqlMetrics.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLW15c3FsL3NyYy9tYWluL2phdmEvY29tL2JhaWR1L2h1Z2VncmFwaC9iYWNrZW5kL3N0b3JlL215c3FsL015c3FsTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...hugegraph/backend/store/raft/RaftStoreClosure.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc3RvcmUvcmFmdC9SYWZ0U3RvcmVDbG9zdXJlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...hugegraph/job/schema/OlapPropertyKeyCreateJob.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2pvYi9zY2hlbWEvT2xhcFByb3BlcnR5S2V5Q3JlYXRlSm9iLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...hugegraph/job/schema/OlapPropertyKeyRemoveJob.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2pvYi9zY2hlbWEvT2xhcFByb3BlcnR5S2V5UmVtb3ZlSm9iLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ugegraph/backend/store/memory/InMemoryMetrics.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNvcmUvc3JjL21haW4vamF2YS9jb20vYmFpZHUvaHVnZWdyYXBoL2JhY2tlbmQvc3RvcmUvbWVtb3J5L0luTWVtb3J5TWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...egraph/backend/store/hbase/HbaseStoreProvider.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWhiYXNlL3NyYy9tYWluL2phdmEvY29tL2JhaWR1L2h1Z2VncmFwaC9iYWNrZW5kL3N0b3JlL2hiYXNlL0hiYXNlU3RvcmVQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...egraph/backend/store/scylladb/ScyllaDBMetrics.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLXNjeWxsYWRiL3NyYy9tYWluL2phdmEvY29tL2JhaWR1L2h1Z2VncmFwaC9iYWNrZW5kL3N0b3JlL3NjeWxsYWRiL1NjeWxsYURCTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...graph/backend/store/scylladb/ScyllaDBFeatures.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLXNjeWxsYWRiL3NyYy9tYWluL2phdmEvY29tL2JhaWR1L2h1Z2VncmFwaC9iYWNrZW5kL3N0b3JlL3NjeWxsYWRiL1NjeWxsYURCRmVhdHVyZXMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [198 more](https://codecov.io/gh/apache/incubator-hugegraph/pull/1883/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1883?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1883?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f6f8c3e...2e4f08a](https://codecov.io/gh/apache/incubator-hugegraph/pull/1883?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] javeme commented on pull request #1883: fix bug: get profile api cannot be accessed #1882
Posted by GitBox <gi...@apache.org>.
javeme commented on PR #1883:
URL: https://github.com/apache/incubator-hugegraph/pull/1883#issuecomment-1127183670
@zyxxoo Do you think this issue may be caused by upgrading jersey?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #1883: fix bug: get profile api cannot be accessed #1882
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #1883:
URL: https://github.com/apache/incubator-hugegraph/pull/1883#discussion_r884068543
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/api/profile/ProfileAPI.java:
##########
@@ -59,6 +59,7 @@ public class ProfileAPI {
private static String API_PROFILES = null;
@GET
+ @Path("profiles")
Review Comment:
OK, let's keep the original url
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] wangyao2016 closed pull request #1883: fix bug: get profile api cannot be accessed #1882
Posted by GitBox <gi...@apache.org>.
wangyao2016 closed pull request #1883: fix bug: get profile api cannot be accessed #1882
URL: https://github.com/apache/incubator-hugegraph/pull/1883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #1883: fix bug: get profile api cannot be accessed #1882
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #1883:
URL: https://github.com/apache/incubator-hugegraph/pull/1883#discussion_r873479119
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/api/profile/ProfileAPI.java:
##########
@@ -59,6 +59,7 @@ public class ProfileAPI {
private static String API_PROFILES = null;
@GET
+ @Path("profiles")
Review Comment:
Thanks for pointing out the root cause.
IMO we cam add url "/" to WHITE_API_LIST to keep the continuity.
@corgiboygsj could you please also take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #1883: fix bug: get profile api cannot be accessed #1882
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #1883:
URL: https://github.com/apache/incubator-hugegraph/pull/1883#discussion_r873479119
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/api/profile/ProfileAPI.java:
##########
@@ -59,6 +59,7 @@ public class ProfileAPI {
private static String API_PROFILES = null;
@GET
+ @Path("profiles")
Review Comment:
Thanks for pointing out the root cause.
IMO we cam add url "/" to WHITE_API_LIST to keep the continuity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] wangyao2016 commented on a diff in pull request #1883: fix bug: get profile api cannot be accessed #1882
Posted by GitBox <gi...@apache.org>.
wangyao2016 commented on code in PR #1883:
URL: https://github.com/apache/incubator-hugegraph/pull/1883#discussion_r873380534
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/api/profile/ProfileAPI.java:
##########
@@ -59,6 +59,7 @@ public class ProfileAPI {
private static String API_PROFILES = null;
@GET
+ @Path("profiles")
Review Comment:
Modify the check rule or just change routing to "/profiles"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #1883: fix bug: get profile api cannot be accessed #1882
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #1883:
URL: https://github.com/apache/incubator-hugegraph/pull/1883#discussion_r873301723
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/api/profile/ProfileAPI.java:
##########
@@ -59,6 +59,7 @@ public class ProfileAPI {
private static String API_PROFILES = null;
@GET
+ @Path("profiles")
Review Comment:
can we fix this issue and keep the origin url path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] corgiboygsj commented on a diff in pull request #1883: fix bug: get profile api cannot be accessed #1882
Posted by GitBox <gi...@apache.org>.
corgiboygsj commented on code in PR #1883:
URL: https://github.com/apache/incubator-hugegraph/pull/1883#discussion_r883293773
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/api/profile/ProfileAPI.java:
##########
@@ -59,6 +59,7 @@ public class ProfileAPI {
private static String API_PROFILES = null;
@GET
+ @Path("profiles")
Review Comment:
I didn't notice that ProfileApi would use an blank url. So in order to keep the original url, I chose to delete the blank url check. #1893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org