You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/10/23 02:44:13 UTC
[GitHub] [helix] narendly commented on issue #520: Refactoring soft
constraints to simply the algorithm and fix potential issues.
narendly commented on issue #520: Refactoring soft constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#issuecomment-545239413
@jiajunwang Also from now on, please try to keep PRs separate. Structural changes could go in one PR, and logic change could go in another. I know it's just tempting and feels faster to do everything in one, but this PR clearly has gotten too big. I'll discuss with you offline to clear up some confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org