svn commit: r1695141 - in /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile: MethodParameter.java MethodParameters.java

[se...@apache.org]

Author: sebb
Date: Mon Aug 10 17:27:54 2015
New Revision: 1695141

URL: http://svn.apache.org/r1695141
Log:
TODOs

Modified:
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/MethodParameter.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/MethodParameters.java

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/MethodParameter.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/MethodParameter.java?rev=1695141&r1=1695140&r2=1695141&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/MethodParameter.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/MethodParameter.java Mon Aug 10 17:27:54 2015
@@ -35,10 +35,10 @@ public class MethodParameter implements
     private static final long serialVersionUID = 6014494029439440326L;
 
     /** Index of the CONSTANT_Utf8_info structure in the constant_pool table representing the name of the parameter */
-    private int name_index;
+    private int name_index; // TODO could be final (setter unused)
 
     /** The access flags */
-    private int access_flags;
+    private int access_flags; // TODO could be final (setter unused)
 
     public MethodParameter() {
     }
@@ -59,7 +59,7 @@ public class MethodParameter implements
         return name_index;
     }
 
-    public void setNameIndex(int name_index) {
+    public void setNameIndex(int name_index) { // TODO unused
         this.name_index = name_index;
     }
 
@@ -77,7 +77,7 @@ public class MethodParameter implements
         return access_flags;
     }
 
-    public void setAccessFlags(int access_flags) {
+    public void setAccessFlags(int access_flags) { // TODO unused
         this.access_flags = access_flags;
     }
 

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/MethodParameters.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/MethodParameters.java?rev=1695141&r1=1695140&r2=1695141&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/MethodParameters.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/MethodParameters.java Mon Aug 10 17:27:54 2015
@@ -33,11 +33,10 @@ public class MethodParameters extends At
 
     private static final long serialVersionUID = 2500272580422360140L;
 
-    private MethodParameter[] parameters = new MethodParameter[0];
+    private MethodParameter[] parameters = new MethodParameter[0]; // TODO could be final (setter unused)
 
     MethodParameters(int name_index, int length, DataInput input, ConstantPool constant_pool) throws IOException {
         super(Constants.ATTR_METHOD_PARAMETERS, name_index, length, constant_pool);
-        System.out.println("new MethodParameters");
 
         int parameters_count = input.readUnsignedByte();
         parameters = new MethodParameter[parameters_count];
@@ -50,7 +49,7 @@ public class MethodParameters extends At
         return parameters;
     }
 
-    public void setParameters(MethodParameter[] parameters) {
+    public void setParameters(MethodParameter[] parameters) { // TODO unused
         this.parameters = parameters;
     }