You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/01/29 17:16:01 UTC

[GitHub] abaruni commented on a change in pull request #238: Adjust threshold of authentication errors with brokers before disabling consumer

abaruni commented on a change in pull request #238: Adjust threshold of authentication errors with brokers before disabling consumer
URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/238#discussion_r164499648
 
 

 ##########
 File path: provider/consumer.py
 ##########
 @@ -133,6 +133,18 @@ def __init__(self, trigger, params, sharedDictionary):
 
         self.authErrors = 0
 
+        # We want to account for the number of brokers when deciding the maximum number
+        # number of auth errors to allow
+        self.maxAuthErrors = len(self.brokers) * 30
 
 Review comment:
   is this enough? should it be 50 attempts per broker? 100?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services