You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bookkeeper.apache.org by eolivelli <gi...@git.apache.org> on 2017/04/18 15:04:15 UTC

[GitHub] bookkeeper pull request #131: Fix findbugs warnings

GitHub user eolivelli opened a pull request:

    https://github.com/apache/bookkeeper/pull/131

    Fix findbugs warnings

    - upgrade to findbugs 3.0.4
    - fix DLS_DEAD_LOCAL_STORE At BookieInfoReader.java (introduce a constant)
    - fix EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC At PerChannelBookieClient.java (introduce a V3CompletionKey)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/eolivelli/bookkeeper BOOKKEEPER-1038-findbugs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bookkeeper/pull/131.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #131
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bookkeeper pull request #131: BOOKKEEPER-1038 Fix findbugs warnings and upgr...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/bookkeeper/pull/131


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bookkeeper issue #131: BOOKKEEPER-1038 Fix findbugs warnings and upgrade to ...

Posted by eolivelli <gi...@git.apache.org>.

Github user eolivelli commented on the issue:

    https://github.com/apache/bookkeeper/pull/131
  
    @sijie done, sorry it was a copy and paste error


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bookkeeper issue #131: Fix findbugs warnings

Posted by sijie <gi...@git.apache.org>.

Github user sijie commented on the issue:

    https://github.com/apache/bookkeeper/pull/131
  
    @eolivelli can you change the caption "BOOKKEEPER-xxx: yyyy"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---