You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/11 20:39:58 UTC

[GitHub] [airflow] ashb opened a new pull request #14732: Remove un-needed/left over environment variables in ci.yml

ashb opened a new pull request #14732:
URL: https://github.com/apache/airflow/pull/14732


   AIRFLOW_COMMITERS was left over from a previous PR and should have never
   been included.
   
   EVENT_NAME isn't needed as GitHub already provide us a GITHUB_EVENT_NAME
   with the same value


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on pull request #14732: Remove un-needed/left over environment variables in ci.yml

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14732:
URL: https://github.com/apache/airflow/pull/14732#issuecomment-797061458


   > Commit SHA passed: 750e522208b847425683fcc2f8cd138a1068011c!
   
   It's run the changed bits fine, merging now without waiting for full tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb merged pull request #14732: Remove un-needed/left over environment variables in ci.yml

Posted by GitBox <gi...@apache.org>.
ashb merged pull request #14732:
URL: https://github.com/apache/airflow/pull/14732


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on a change in pull request #14732: Remove un-needed/left over environment variables in ci.yml

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #14732:
URL: https://github.com/apache/airflow/pull/14732#discussion_r592707651



##########
File path: .github/workflows/ci.yml
##########
@@ -208,11 +207,12 @@ jobs:
       - name: Selective checks
         id: selective-checks
         env:
-          EVENT_NAME: ${{ github.event_name }}
           TARGET_COMMIT_SHA: ${{ github.sha }}
           PR_LABELS: "${{ steps.source-run-info.outputs.pullRequestLabels }}"
         run: |
-          if [[ ${EVENT_NAME} == "pull_request" ]]; then
+          set -x
+          echo "${TARGET_COMMIT_SHA} ${GITHUB_SHA}"

Review comment:
       Just testing, I think this isn't needed either.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #14732: Remove un-needed/left over environment variables in ci.yml

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14732:
URL: https://github.com/apache/airflow/pull/14732#issuecomment-797060582


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org