[GitHub] spark pull request: [SPARK-10017] [MLlib]: ML model broadcasts sho...

[jkbradley <gi...@git.apache.org>]

Github user jkbradley commented on the pull request:

    https://github.com/apache/spark/pull/8241#issuecomment-139096528
  
    @sabhyankar Thanks for discussing these issues.  Given the various arguments, I'd vote for:
    * eliminating the trait --- It's a nice idea but seems like it saves too little code to be worthwhile, since there is no easy one-trait-fits-all solution.
    * discussing mutability of models on the JIRA before proceeding --- @mengxr I guess this already affects a number of models which use broadcasts, but you're right we should discuss it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org