[GitHub] [sling-org-apache-sling-feature-cpconverter] bosschaert commented on a change in pull request #23: SLING-8973 - fixing runmode handling for repoinit configuration handling

[GitBox <gi...@apache.org>]

bosschaert commented on a change in pull request #23: SLING-8973 - fixing runmode handling for repoinit configuration handling
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/23#discussion_r364365501
 
 

 ##########
 File path: src/main/java/org/apache/sling/feature/cpconverter/acl/DefaultAclManager.java
 ##########
 @@ -134,7 +134,7 @@ public void addRepoinitExtension(List<VaultPackageAssembler> packageAssemblers,
             String text = formatter.toString();
 
             if (!text.isEmpty()) {
-                featureManager.addOrAppendRepoInitExtension(text);
+                featureManager.addOrAppendRepoInitExtension(text, null);
 
 Review comment:
   Would it make sense to add an extra override to addOrAppendRepoInitExtension() with a single argument that calls the other one with `null` as the second argument? That way we don't have to specify `null` everywhere in the code where we don't need runmodes?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services