You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2011/03/09 06:03:59 UTC
[jira] Created: (WHIRR-250) Ensure all libraries in binary
distribution have associated licenses where stipulated
Ensure all libraries in binary distribution have associated licenses where stipulated
-------------------------------------------------------------------------------------
Key: WHIRR-250
URL: https://issues.apache.org/jira/browse/WHIRR-250
Project: Whirr
Issue Type: Bug
Reporter: Tom White
Assignee: Tom White
Priority: Blocker
Fix For: 0.4.0
As pointed out on general@incubator (http://mail-archives.apache.org/mod_mbox/incubator-general/201103.mbox/%3C87aah5g30g.fsf@v35516.1blu.de%3E) we need to make sure that jars in the binary distribution have associated licenses. The upgrade to jclouds beta-9 added/renamed jars.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-250) Ensure all libraries in binary
distribution have associated licenses where stipulated
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004758#comment-13004758 ]
Andrei Savu commented on WHIRR-250:
-----------------------------------
+1 (maybe we should create a script with that snippet. It's going to be useful in the following releases)
> Ensure all libraries in binary distribution have associated licenses where stipulated
> -------------------------------------------------------------------------------------
>
> Key: WHIRR-250
> URL: https://issues.apache.org/jira/browse/WHIRR-250
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Priority: Blocker
> Fix For: 0.4.0
>
> Attachments: WHIRR-250.patch, WHIRR-250.patch
>
>
> As pointed out on general@incubator (http://mail-archives.apache.org/mod_mbox/incubator-general/201103.mbox/%3C87aah5g30g.fsf@v35516.1blu.de%3E) we need to make sure that jars in the binary distribution have associated licenses. The upgrade to jclouds beta-9 added/renamed jars.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (WHIRR-250) Ensure all libraries in binary
distribution have associated licenses where stipulated
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu resolved WHIRR-250.
-------------------------------
Resolution: Fixed
I've just committed this. Thanks Tom!
> Ensure all libraries in binary distribution have associated licenses where stipulated
> -------------------------------------------------------------------------------------
>
> Key: WHIRR-250
> URL: https://issues.apache.org/jira/browse/WHIRR-250
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Priority: Blocker
> Fix For: 0.4.0
>
> Attachments: WHIRR-250.patch, WHIRR-250.patch, WHIRR-250.patch
>
>
> As pointed out on general@incubator (http://mail-archives.apache.org/mod_mbox/incubator-general/201103.mbox/%3C87aah5g30g.fsf@v35516.1blu.de%3E) we need to make sure that jars in the binary distribution have associated licenses. The upgrade to jclouds beta-9 added/renamed jars.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WHIRR-250) Ensure all libraries in binary
distribution have associated licenses where stipulated
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-250:
------------------------------
Attachment: WHIRR-250.patch
I've also added cloudservers-uk to the list of supported cloud providers.
> Ensure all libraries in binary distribution have associated licenses where stipulated
> -------------------------------------------------------------------------------------
>
> Key: WHIRR-250
> URL: https://issues.apache.org/jira/browse/WHIRR-250
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Priority: Blocker
> Fix For: 0.4.0
>
> Attachments: WHIRR-250.patch, WHIRR-250.patch, WHIRR-250.patch
>
>
> As pointed out on general@incubator (http://mail-archives.apache.org/mod_mbox/incubator-general/201103.mbox/%3C87aah5g30g.fsf@v35516.1blu.de%3E) we need to make sure that jars in the binary distribution have associated licenses. The upgrade to jclouds beta-9 added/renamed jars.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-250) Ensure all libraries in binary
distribution have associated licenses where stipulated
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004680#comment-13004680 ]
Tom White commented on WHIRR-250:
---------------------------------
I created http://code.google.com/p/jclouds/issues/detail?id=503 to request that jclouds add LICENSE files to its published JARs.
> Ensure all libraries in binary distribution have associated licenses where stipulated
> -------------------------------------------------------------------------------------
>
> Key: WHIRR-250
> URL: https://issues.apache.org/jira/browse/WHIRR-250
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Priority: Blocker
> Fix For: 0.4.0
>
> Attachments: WHIRR-250.patch
>
>
> As pointed out on general@incubator (http://mail-archives.apache.org/mod_mbox/incubator-general/201103.mbox/%3C87aah5g30g.fsf@v35516.1blu.de%3E) we need to make sure that jars in the binary distribution have associated licenses. The upgrade to jclouds beta-9 added/renamed jars.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-250) Ensure all libraries in binary
distribution have associated licenses where stipulated
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005265#comment-13005265 ]
Tom White commented on WHIRR-250:
---------------------------------
+1
> Ensure all libraries in binary distribution have associated licenses where stipulated
> -------------------------------------------------------------------------------------
>
> Key: WHIRR-250
> URL: https://issues.apache.org/jira/browse/WHIRR-250
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Priority: Blocker
> Fix For: 0.4.0
>
> Attachments: WHIRR-250.patch, WHIRR-250.patch, WHIRR-250.patch
>
>
> As pointed out on general@incubator (http://mail-archives.apache.org/mod_mbox/incubator-general/201103.mbox/%3C87aah5g30g.fsf@v35516.1blu.de%3E) we need to make sure that jars in the binary distribution have associated licenses. The upgrade to jclouds beta-9 added/renamed jars.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-250) Ensure all libraries in binary
distribution have associated licenses where stipulated
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004378#comment-13004378 ]
Tom White commented on WHIRR-250:
---------------------------------
If you look in the lib directory of the binary distibution, some libraries don't have an associated license file - either within the JAR itself, or in the lib directory.
There's some related discussion on WHIRR-100, when we last did this. Basically, every time we add or update a JAR we need to check whether a license file needs adding. It's a manual process, but I don't know a better way.
Trunk is on a different version of jclouds (beta-9b) to the 0.4.0 branch (beta-9), so I suggest that we fix this on trunk and recut 0.4.0. Otherwise we need to do this process twice, and there seem to be quite a few changes to JARs between these two jclouds releases.
Also, the naming of the new jclouds provider JARs makes this harder than before, since before all jclouds JARs had a "jclouds" prefix so we only needed one license file. Now they don't have a "jclouds" prefix (e.g. aws-common-1.0-beta-9b.jar) so it's not clear that they are jclouds related, so we need an accompanying file in lib for each one (as I understand it). We might also consider only shipping the jars for the cloud providers that we currently support.
> Ensure all libraries in binary distribution have associated licenses where stipulated
> -------------------------------------------------------------------------------------
>
> Key: WHIRR-250
> URL: https://issues.apache.org/jira/browse/WHIRR-250
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Priority: Blocker
> Fix For: 0.4.0
>
>
> As pointed out on general@incubator (http://mail-archives.apache.org/mod_mbox/incubator-general/201103.mbox/%3C87aah5g30g.fsf@v35516.1blu.de%3E) we need to make sure that jars in the binary distribution have associated licenses. The upgrade to jclouds beta-9 added/renamed jars.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WHIRR-250) Ensure all libraries in binary
distribution have associated licenses where stipulated
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated WHIRR-250:
----------------------------
Attachment: WHIRR-250.patch
An initial patch - haven't looked at all the jclouds provider libraries yet.
> Ensure all libraries in binary distribution have associated licenses where stipulated
> -------------------------------------------------------------------------------------
>
> Key: WHIRR-250
> URL: https://issues.apache.org/jira/browse/WHIRR-250
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Priority: Blocker
> Fix For: 0.4.0
>
> Attachments: WHIRR-250.patch
>
>
> As pointed out on general@incubator (http://mail-archives.apache.org/mod_mbox/incubator-general/201103.mbox/%3C87aah5g30g.fsf@v35516.1blu.de%3E) we need to make sure that jars in the binary distribution have associated licenses. The upgrade to jclouds beta-9 added/renamed jars.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WHIRR-250) Ensure all libraries in binary
distribution have associated licenses where stipulated
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated WHIRR-250:
----------------------------
Attachment: WHIRR-250.patch
Updated patch to remove unsupported jclouds providers. Each jar in lib either has a license alongside, or inside it. I checked this with:
{noformat}
mvn -DskipTests clean package assembly:directory
for jar in target/whirr-*-incubating-SNAPSHOT/whirr-*-incubating-SNAPSHOT/lib/*.jar; do
if [ ! -e lib/$(basename $jar .jar)-LICENSE.txt ]; then
if ! jar tf $jar | grep -q LICENSE; then
echo "No LICENSE file for $(basename $jar) (either in or alongside the JAR)"
fi
fi
done
{noformat}
The only exception is aopalliance-1.0.jar (public domain) and the jclouds JARS starting with "jclouds" - these are covered by a single license file.
> Ensure all libraries in binary distribution have associated licenses where stipulated
> -------------------------------------------------------------------------------------
>
> Key: WHIRR-250
> URL: https://issues.apache.org/jira/browse/WHIRR-250
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Priority: Blocker
> Fix For: 0.4.0
>
> Attachments: WHIRR-250.patch, WHIRR-250.patch
>
>
> As pointed out on general@incubator (http://mail-archives.apache.org/mod_mbox/incubator-general/201103.mbox/%3C87aah5g30g.fsf@v35516.1blu.de%3E) we need to make sure that jars in the binary distribution have associated licenses. The upgrade to jclouds beta-9 added/renamed jars.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-250) Ensure all libraries in binary
distribution have associated licenses where stipulated
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004560#comment-13004560 ]
Andrei Savu commented on WHIRR-250:
-----------------------------------
+1 for shipping only the jars for the cloud providers that we support.
> Ensure all libraries in binary distribution have associated licenses where stipulated
> -------------------------------------------------------------------------------------
>
> Key: WHIRR-250
> URL: https://issues.apache.org/jira/browse/WHIRR-250
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Priority: Blocker
> Fix For: 0.4.0
>
> Attachments: WHIRR-250.patch
>
>
> As pointed out on general@incubator (http://mail-archives.apache.org/mod_mbox/incubator-general/201103.mbox/%3C87aah5g30g.fsf@v35516.1blu.de%3E) we need to make sure that jars in the binary distribution have associated licenses. The upgrade to jclouds beta-9 added/renamed jars.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira