do not save source (was: Config tree code finished.)

[Greg Stein <gs...@lyra.org>]

On Mon, 24 Apr 2000, William A. Rowe, Jr. wrote:
> > From: rbb@covalent.net [mailto:rbb@covalent.net]
> > Sent: Monday, April 24, 2000 8:05 AM
> > > 
> > > And I concur with Ryan... we want to save the 'source' of the
> > > config so that a mod_info could unwind it later, rather than
> > > wiping out the source and replacing it with the result text.
> > > 
> > 
> > Unfortunately, then we disagree.  I want the resultant config 
> > code.  The
> > perl code is just there so that mod_perl can actually get to 
> > it when it
> > wants to interpret it.
> > 
> > Mod_info doesn't want to see the perl code, it wants to see the result
> > config code.  We only save the perl code until it can be replaced.
> 
> So we do... but I would treat this in the same class as my proposal long
> ago to allow comments to be parsed and stored for mod_info...
> 
> source files can be in the same class as comments, if we don't want to
> regenerate a config file (meaning - we didn't save the comments) then
> we have no need to save the source.
> 
> Consider this an optional apache 2.1 type feature request, in tandem
> with loading comments for unwinding later.

Oooh! Consensus! :-)


I agree here. We should not save the source once operation begins. We
should not save comments. The *only* thing that we save are basic
directive/argument values. That is all that Apache cares about at this
point.

2.1? Sure. And sure, we can defer this discussion until then.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Re: do not save source (was: Config tree code finished.)

[Rodent of Unusual Size <Ke...@Golux.Com>]

Greg Stein wrote:
> 
> Oooh! Consensus! :-)
> 
> I agree here. We should not save the source once operation begins. We
> should not save comments. The *only* thing that we save are basic
> directive/argument values. That is all that Apache cares about at this
> point.

At the moment I disagree; I think we DO want to save the source.
But deferring further discussion until 2.1 is a brilliant idea.
-- 
#ken    P-)}

Ken Coar                    <http://Golux.Com/coar/>
Apache Software Foundation  <http://www.apache.org/>
"Apache Server for Dummies" <http://Apache-Server.Com/>
"Apache Server Unleashed"   <http://ApacheUnleashed.Com/>