[jira] [Commented] (BOOKKEEPER-848) Use volatile for lastAddConfirmed

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490549#comment-14490549 ] 

Hadoop QA commented on BOOKKEEPER-848:
--------------------------------------

Testing JIRA BOOKKEEPER-848


Patch [0001-BOOKKEEPER-848-Use-volatile-for-lastAddConfirmed.patch|https://issues.apache.org/jira/secure/attachment/12724665/0001-BOOKKEEPER-848-Use-volatile-for-lastAddConfirmed.patch] downloaded at Fri Apr 10 23:00:56 UTC 2015

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 120
.    {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 FINDBUGS{color}
.    {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
{color:red}-1 TESTS{color}
.    Tests run: 949
.    Tests failed: 1
.    Tests errors: 1

.    The patch failed the following testcases:

.      testSimpleChat(org.apache.hedwig.jms.BasicJMSTest)

{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/bookkeeper-trunk-precommit-build/920/

> Use volatile for lastAddConfirmed
> ---------------------------------
>
>                 Key: BOOKKEEPER-848
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-848
>             Project: Bookkeeper
>          Issue Type: Bug
>    Affects Versions: 4.3.0
>            Reporter: Matteo Merli
>            Assignee: Matteo Merli
>            Priority: Minor
>             Fix For: 4.4.0
>
>         Attachments: 0001-BOOKKEEPER-848-Use-volatile-for-lastAddConfirmed.patch
>
>
> LastAddConfirmed in LedgerHandle is updated when an entry is persisted successfully. 
> When sending a new entry, the most recent lastAddConfirmed is sent along. The reason is to start with a reasonable (confirmed) entryId when doing ledger recovery, by reading all entries from lastAddConfirmed until a NoEntryException is reached. 
> If lastAddConfirmed updates are not visible to the thread that is writing new entries, new entries will carrie an older lastAddConfirmed value, and recovering the ledger will requiring reading one-by-one many entries.
> When writing several thousand of entries per sec, the lastAddConfirmed can lag behind a lot from the real last entry.
> We should use volatile, to ensure writing thread sees the updated version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)