You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datafu.apache.org by Matthew Hayes <ma...@gmail.com> on 2017/02/17 05:44:31 UTC
Re: [DISCUSS] Datafu graduation from the Incubator
Following up on the LICENSE/NOTICE file issues in the binary artifacts, I
have prepared a patch that includes them in the artifacts, as well as the
DISCLAIMER:
https://issues.apache.org/jira/browse/DATAFU-121
https://reviews.apache.org/r/56779/
Justin and Roman, if you have time can you review these changes? Feedback
from others is welcome too. I'll explain how I prepared these:
1) Both datafu-hourglass and datafu-pig include LICENSE, NOTICE, and
DISCLAIMER files under META-INF inside the JARs. The DISCLAIMER is the
same for each. For the the other two files they are different.
2) datafu-hourglass JAR does not bundle any dependencies, so the LICENSE
and NOTICE files are boilerplate.
3) datafu-pig JAR bundles several Apache-2.0-licensed JARs (and no
non-Apache-2.0 licensed JARs). I reviewed the LICENSE and NOTICE files for
each of the bundled dependencies. The only case I found where there was a
non-boilerplate LICENSE/NOTICE provided was Apache commons-math. I copied
the NOTICE and LICENSE contents to the datafu-pig JAR's NOTICE and LICENSE
files, respectively.
4) I disabled generation of sources and javadoc JARs to avoid the build
issues I was experiencing trying to package these LICENSE and NOTICE
files. We can enable these later once the issues are resolved.
Thanks,
Matt
On Tue, Aug 16, 2016 at 5:41 PM, Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> > Also, does every JAR need these included?
>
> If it ASF Apache V2 licensed yes.
>
> > datafu-pig bundles the dependencies listed below.
> >
> > The LICENSE and NOTICE files have not been updated to reflect this
> bundling
> > because this did not impact the source release.
>
> The LICENSE and NOTICE will need to reflect the contents of the zip/jar so
> it's very likely they need to be different. [1]
>
> If may also be that those bundled products bundle other products so you’ll
> need to check that. It may be some of those Apache bundled items have a
> NOTICE files that in turn affects your NOTICE file. [2]
>
> > Where should information on these dependencies be included?
>
> Dependancies effect LICENSE/NOTICE only if they are bundled [3], there's
> no requirement to list other dependancies. However all dependancies (with a
> few exceptions) must be compatible with the Apache v2 license. On how to
> handle Apache v2 licensed software see [2].
>
> Thanks,
> Justin
>
> 1. http://www.apache.org/dev/licensing-howto.html#binary
> 2. http://www.apache.org/dev/licensing-howto.html#alv2-dep
> 3. http://www.apache.org/dev/licensing-howto.html#guiding-principle
Re: [DISCUSS] Datafu graduation from the Incubator
Posted by Matthew Hayes <ma...@gmail.com>.
Thanks very much Roman and Russell for your reviews. I will merge in the
changes and start preparing for a release to include these updates.
-Matt
On Sat, Feb 18, 2017 at 9:24 PM, Roman Shaposhnik <ro...@shaposhnik.org>
wrote:
> On Thu, Feb 16, 2017 at 9:44 PM, Matthew Hayes
> <ma...@gmail.com> wrote:
> > Following up on the LICENSE/NOTICE file issues in the binary artifacts, I
> > have prepared a patch that includes them in the artifacts, as well as the
> > DISCLAIMER:
> >
> > https://issues.apache.org/jira/browse/DATAFU-121
> > https://reviews.apache.org/r/56779/
> >
> > Justin and Roman, if you have time can you review these changes?
>
> +1. Manually verified your change and the correct META-INF content was
> observed for both jars
>
> > Feedback
> > from others is welcome too. I'll explain how I prepared these:
> >
> > 1) Both datafu-hourglass and datafu-pig include LICENSE, NOTICE, and
> > DISCLAIMER files under META-INF inside the JARs. The DISCLAIMER is the
> > same for each. For the the other two files they are different.
> > 2) datafu-hourglass JAR does not bundle any dependencies, so the LICENSE
> > and NOTICE files are boilerplate.
>
> Makes sense
>
> > 3) datafu-pig JAR bundles several Apache-2.0-licensed JARs (and no
> > non-Apache-2.0 licensed JARs). I reviewed the LICENSE and NOTICE files
> for
> > each of the bundled dependencies. The only case I found where there was
> a
> > non-boilerplate LICENSE/NOTICE provided was Apache commons-math. I
> copied
> > the NOTICE and LICENSE contents to the datafu-pig JAR's NOTICE and
> LICENSE
> > files, respectively.
>
> I manually compared these two and it looks OK to me.
>
> > 4) I disabled generation of sources and javadoc JARs to avoid the build
> > issues I was experiencing trying to package these LICENSE and NOTICE
> > files. We can enable these later once the issues are resolved.
>
> Sounds good.
>
> Thanks,
> Roman.
>
Re: [DISCUSS] Datafu graduation from the Incubator
Posted by Roman Shaposhnik <ro...@shaposhnik.org>.
On Thu, Feb 16, 2017 at 9:44 PM, Matthew Hayes
<ma...@gmail.com> wrote:
> Following up on the LICENSE/NOTICE file issues in the binary artifacts, I
> have prepared a patch that includes them in the artifacts, as well as the
> DISCLAIMER:
>
> https://issues.apache.org/jira/browse/DATAFU-121
> https://reviews.apache.org/r/56779/
>
> Justin and Roman, if you have time can you review these changes?
+1. Manually verified your change and the correct META-INF content was
observed for both jars
> Feedback
> from others is welcome too. I'll explain how I prepared these:
>
> 1) Both datafu-hourglass and datafu-pig include LICENSE, NOTICE, and
> DISCLAIMER files under META-INF inside the JARs. The DISCLAIMER is the
> same for each. For the the other two files they are different.
> 2) datafu-hourglass JAR does not bundle any dependencies, so the LICENSE
> and NOTICE files are boilerplate.
Makes sense
> 3) datafu-pig JAR bundles several Apache-2.0-licensed JARs (and no
> non-Apache-2.0 licensed JARs). I reviewed the LICENSE and NOTICE files for
> each of the bundled dependencies. The only case I found where there was a
> non-boilerplate LICENSE/NOTICE provided was Apache commons-math. I copied
> the NOTICE and LICENSE contents to the datafu-pig JAR's NOTICE and LICENSE
> files, respectively.
I manually compared these two and it looks OK to me.
> 4) I disabled generation of sources and javadoc JARs to avoid the build
> issues I was experiencing trying to package these LICENSE and NOTICE
> files. We can enable these later once the issues are resolved.
Sounds good.
Thanks,
Roman.