You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "SunnyChaturvedi (via GitHub)" <gi...@apache.org> on 2023/02/24 15:15:49 UTC
[GitHub] [kafka] SunnyChaturvedi opened a new pull request, #13299: MINOR: Fix flaky testIdleConnection() test (cherry-pick from apache/kafka#11996)
SunnyChaturvedi opened a new pull request, #13299:
URL: https://github.com/apache/kafka/pull/13299
The fix is in the upstream trunk (apache/kafka#11996)
The test expects that the connection becomes idle before the mock time is moved forward, but the processor thread runs concurrently and may run some activity on the connection after the mock time is moved forward, thus the connection never expires.
The solution is to wait until the message is received on the socket, and only then wait until the connection is unmuted (it's not enough to wait for unmuted without waiting for message being received on the socket, because the channel might have not been muted yet).
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13299: MINOR: Fix flaky testIdleConnection() test (cherry-pick from apache/kafka #11996)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13299:
URL: https://github.com/apache/kafka/pull/13299#issuecomment-1722708197
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix flaky testIdleConnection() test (cherry-pick from apache/kafka #11996) [kafka]
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya closed pull request #13299: MINOR: Fix flaky testIdleConnection() test (cherry-pick from apache/kafka #11996)
URL: https://github.com/apache/kafka/pull/13299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13299: MINOR: Fix flaky testIdleConnection() test (cherry-pick from apache/kafka #11996)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13299:
URL: https://github.com/apache/kafka/pull/13299#issuecomment-1585813152
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch)
If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix flaky testIdleConnection() test (cherry-pick from apache/kafka #11996) [kafka]
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #13299:
URL: https://github.com/apache/kafka/pull/13299#issuecomment-1783148515
Hey @SunnyChaturvedi
It's unlikely that we will do a release for 3.2 at this stage since it's considered End of Life (EOL) as per https://cwiki.apache.org/confluence/display/KAFKA/Time+Based+Release+Plan#TimeBasedReleasePlan-WhatIsOurEOLPolicy?
I am closing this PR. Please feel free to reopen if you think otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org