You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "shwstppr (via GitHub)" <gi...@apache.org> on 2023/04/04 10:35:11 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request, #7398: server,engine-schema: fix listing service offering for vm scale
shwstppr opened a new pull request, #7398:
URL: https://github.com/apache/cloudstack/pull/7398
### Description
Fixes #7389
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7398: server,engine-schema: fix listing service offering for vm scale
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7398:
URL: https://github.com/apache/cloudstack/pull/7398#issuecomment-1495845014
## [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7398?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7398](https://codecov.io/gh/apache/cloudstack/pull/7398?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6511139) into [4.18](https://codecov.io/gh/apache/cloudstack/commit/5d5fa04c8ba848b57511f07139f968ba253f5167?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5d5fa04) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## 4.18 #7398 +/- ##
=========================================
Coverage 12.69% 12.69%
Complexity 8661 8661
=========================================
Files 2717 2717
Lines 256168 256171 +3
Branches 39928 39928
=========================================
+ Hits 32527 32528 +1
- Misses 219506 219508 +2
Partials 4135 4135
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...main/java/com/cloud/service/ServiceOfferingVO.java](https://codecov.io/gh/apache/cloudstack/pull/7398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9zZXJ2aWNlL1NlcnZpY2VPZmZlcmluZ1ZPLmphdmE=) | `36.42% <0.00%> (-0.27%)` | :arrow_down: |
| [.../apache/cloudstack/quota/vo/ServiceOfferingVO.java](https://codecov.io/gh/apache/cloudstack/pull/7398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZnJhbWV3b3JrL3F1b3RhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3F1b3RhL3ZvL1NlcnZpY2VPZmZlcmluZ1ZPLmphdmE=) | `0.00% <0.00%> (ø)` | |
... and [1 file with indirect coverage changes](https://codecov.io/gh/apache/cloudstack/pull/7398/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7398: server,engine-schema: fix listing service offering for vm scale
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7398:
URL: https://github.com/apache/cloudstack/pull/7398#issuecomment-1498376848
<b>Trillian test result (tid-6383)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46600 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7398-t6383-kvm-centos7.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #7398: server,engine-schema: fix listing service offering for vm scale
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #7398:
URL: https://github.com/apache/cloudstack/pull/7398#issuecomment-1495737745
@harikrishna-patnala cc @sbrueseke this PR fixes the listing of the current custom offering but now it just lists offerings that use the same disk offering when disk_offering_strictness=true. Is this correct behaviour?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sbrueseke commented on pull request #7398: server,engine-schema: fix listing service offering for vm scale
Posted by "sbrueseke (via GitHub)" <gi...@apache.org>.
sbrueseke commented on PR #7398:
URL: https://github.com/apache/cloudstack/pull/7398#issuecomment-1495864120
@shwstppr great, thank you very much! To me it makes sense that you only see offerings with the same disk offering when disk_offering_strictness=true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a diff in pull request #7398: server,engine-schema: fix listing service offering for vm scale
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on code in PR #7398:
URL: https://github.com/apache/cloudstack/pull/7398#discussion_r1162688180
##########
framework/quota/src/main/java/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java:
##########
@@ -149,6 +149,7 @@ public ServiceOfferingVO(ServiceOfferingVO offering) {
vmType = offering.getSystemVmType();
systemUse = offering.isSystemUse();
dynamicScalingEnabled = offering.isDynamicScalingEnabled();
+ diskOfferingStrictness = offering.diskOfferingStrictness;
Review Comment:
@DaanHoogland will create a cleanup PR for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7398: server,engine-schema: fix listing service offering for vm scale
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7398:
URL: https://github.com/apache/cloudstack/pull/7398#issuecomment-1495856532
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7398: server,engine-schema: fix listing service offering for vm scale
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7398:
URL: https://github.com/apache/cloudstack/pull/7398#issuecomment-1495826242
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7398)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7398&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7398&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7398&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7398&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7398&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7398&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7398&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7398&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7398&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7398&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7398&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7398&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7398&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7398&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7398&metric=new_duplicated_lines_density&view=list) [22.2% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7398&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7398: server,engine-schema: fix listing service offering for vm scale
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7398:
URL: https://github.com/apache/cloudstack/pull/7398#issuecomment-1495956376
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #7398: server,engine-schema: fix listing service offering for vm scale
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #7398:
URL: https://github.com/apache/cloudstack/pull/7398#issuecomment-1496054579
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7398: server,engine-schema: fix listing service offering for vm scale
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7398:
URL: https://github.com/apache/cloudstack/pull/7398#issuecomment-1497395220
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] server,engine-schema: fix listing service offering for vm scale [cloudstack]
Posted by "sbrueseke (via GitHub)" <gi...@apache.org>.
sbrueseke commented on PR #7398:
URL: https://github.com/apache/cloudstack/pull/7398#issuecomment-2285483884
it looks like this fix was left out of 4.19.1.1?!?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #7398: server,engine-schema: fix listing service offering for vm scale
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #7398:
URL: https://github.com/apache/cloudstack/pull/7398#issuecomment-1506742156
@weizhouapache done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7398: server,engine-schema: fix listing service offering for vm scale
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #7398:
URL: https://github.com/apache/cloudstack/pull/7398#issuecomment-1495840174
yes @shwstppr I think we are enforcing this service layer, it can be while listing the offering as well.
Since disk offering strictness is true then root disk offering cannot be changed, so makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #7398: server,engine-schema: fix listing service offering for vm scale
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #7398:
URL: https://github.com/apache/cloudstack/pull/7398#issuecomment-1495854814
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #7398: server,engine-schema: fix listing service offering for vm scale
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #7398:
URL: https://github.com/apache/cloudstack/pull/7398#issuecomment-1497394302
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7398: server,engine-schema: fix listing service offering for vm scale
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7398:
URL: https://github.com/apache/cloudstack/pull/7398#discussion_r1159418464
##########
framework/quota/src/main/java/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java:
##########
@@ -149,6 +149,7 @@ public ServiceOfferingVO(ServiceOfferingVO offering) {
vmType = offering.getSystemVmType();
systemUse = offering.isSystemUse();
dynamicScalingEnabled = offering.isDynamicScalingEnabled();
+ diskOfferingStrictness = offering.diskOfferingStrictness;
Review Comment:
I think this file should be removed and not maintained, It pertains to the same table as https://github.com/apache/cloudstack/pull/7398/files#diff-bbbf939d866dbaec16b3c9ce76664ab203f7ba2a914e29772f795dd44a2cf993 and does not add value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7398: server,engine-schema: fix listing service offering for vm scale
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7398:
URL: https://github.com/apache/cloudstack/pull/7398#issuecomment-1496055047
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr merged pull request #7398: server,engine-schema: fix listing service offering for vm scale
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr merged PR #7398:
URL: https://github.com/apache/cloudstack/pull/7398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a diff in pull request #7398: server,engine-schema: fix listing service offering for vm scale
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on code in PR #7398:
URL: https://github.com/apache/cloudstack/pull/7398#discussion_r1168359832
##########
framework/quota/src/main/java/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java:
##########
@@ -149,6 +149,7 @@ public ServiceOfferingVO(ServiceOfferingVO offering) {
vmType = offering.getSystemVmType();
systemUse = offering.isSystemUse();
dynamicScalingEnabled = offering.isDynamicScalingEnabled();
+ diskOfferingStrictness = offering.diskOfferingStrictness;
Review Comment:
@DaanHoogland created a PR here, https://github.com/apache/cloudstack/pull/7439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org