You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2024/03/04 20:18:08 UTC
(superset) branch test-ci updated: chore: Test
This is an automated email from the ASF dual-hosted git repository.
michaelsmolina pushed a commit to branch test-ci
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/test-ci by this push:
new 813300b003 chore: Test
813300b003 is described below
commit 813300b00330e0fe8afec82a62627658deb0532c
Author: Michael S. Molina <mi...@gmail.com>
AuthorDate: Mon Mar 4 15:17:53 2024 -0500
chore: Test
---
CONTRIBUTING.md | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 4afa69eb2e..70df4a2835 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -38,7 +38,7 @@ little bit helps, and credit will always be given.
- [Pull Request Guidelines](#pull-request-guidelines)
- [Protocol](#protocol)
- [Authoring](#authoring)
- - [Reviewing](#reviewing)
+ - [Reviaewing](#reviewing)
- [Test Environments](#test-environments)
- [Merging](#merging)
- [Post-merge Responsibility](#post-merge-responsibility)
@@ -217,7 +217,7 @@ Security team members must:
- Have an [ICLA](https://www.apache.org/licenses/contributor-agreements.html) signed with Apache Software Foundation.
- Not reveal information about pending and unfixed security issues to anyone (including their employers) unless specifically authorised by the security team members, e.g., if the security team agrees that diagnosing and solving an issue requires the involvement of external experts.
-A release manager, the contributor overseeing the release of a specific version of Apache Superset, is by default a member of the security team. However, they are not expected to be active in assessing, discussing, and fixing security issues.
+A release manager, the contributor overseeing the release of a specific version of Apache Superset, is by default a member of the security team. However, they are not expected to be active in assessing, discussing, and fixing security issues.
Security team members should also follow these general expectations:
@@ -374,8 +374,8 @@ Triaging goals
First, add **Category labels (a.k.a. hash labels)**. Every issue/PR must have one hash label (except spam entry). Labels that begin with `#` defines issue/PR type:
-| Label | for Issue | for PR |
-| --------------- | ----------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------- |
+| Label | for Issue | for PR |
+| --------------- | ----------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------- |
| `#bug` | Bug report | Bug fix |
| `#code-quality` | Describe problem with code, architecture or productivity | Refactor, tests, tooling |
| `#feature` | New feature request | New feature implementation |
@@ -648,22 +648,28 @@ If while using the above commands you encounter an error related to the limit of
```bash
Error: ENOSPC: System limit for number of file watchers reached
```
+
The error is thrown because the number of files monitored by the system has reached the limit.
You can address this this error by increasing the number of inotify watchers.
The current value of max watches can be checked with:
+
```bash
cat /proc/sys/fs/inotify/max_user_watches
```
+
Edit the file /etc/sysctl.conf to increase this value.
The value needs to be decided based on the system memory [(see this StackOverflow answer for more context)](https://stackoverflow.com/questions/535768/what-is-a-reasonable-amount-of-inotify-watches-with-linux).
Open the file in editor and add a line at the bottom specifying the max watches values.
+
```bash
fs.inotify.max_user_watches=524288
```
+
Save the file and exit editor.
To confirm that the change succeeded, run the following command to load the updated value of max_user_watches from sysctl.conf:
+
```bash
sudo sysctl -p
```