You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2019/12/30 09:26:11 UTC
[GitHub] [maven-assembly-plugin] wilx opened a new pull request #15:
MASSEMBLY-922 - allow to override UID/GID for files stored in TAR
wilx opened a new pull request #15: MASSEMBLY-922 - allow to override UID/GID for files stored in TAR
URL: https://github.com/apache/maven-assembly-plugin/pull/15
This implements properties for assembly configuration that allow overriding UID/GID of files in TAR archive and any other archive for which plexus-archiver supports overriding of UID/GID.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MASSEMBLY-922) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MASSEMBLY-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MASSEMBLY-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ x] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-assembly-plugin] wilx commented on a change in pull request
#15: MASSEMBLY-922 - allow to override UID/GID for files stored in TAR
Posted by GitBox <gi...@apache.org>.
wilx commented on a change in pull request #15: MASSEMBLY-922 - allow to override UID/GID for files stored in TAR
URL: https://github.com/apache/maven-assembly-plugin/pull/15#discussion_r362092317
##########
File path: src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java
##########
@@ -404,6 +404,32 @@
@Parameter( defaultValue = "${project.build.outputTimestamp}" )
private String outputTimestamp;
+ /**
+ * Override of user ID in archive type which can store it.
+ */
+ @Parameter( property = "assembly.overrideUid" )
Review comment:
IMHO, it seems nice to be able to do it via command line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-assembly-plugin] rfscholte commented on a change in pull
request #15: MASSEMBLY-922 - allow to override UID/GID for files stored in
TAR
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #15: MASSEMBLY-922 - allow to override UID/GID for files stored in TAR
URL: https://github.com/apache/maven-assembly-plugin/pull/15#discussion_r362079764
##########
File path: src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java
##########
@@ -404,6 +404,32 @@
@Parameter( defaultValue = "${project.build.outputTimestamp}" )
private String outputTimestamp;
+ /**
+ * Override of user ID in archive type which can store it.
+ */
+ @Parameter( property = "assembly.overrideUid" )
Review comment:
Ah, another question: does it make sense to set this via the commandline (`-Dkey=value`). I don't think so, or in other words: just use `@Parameter`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-assembly-plugin] wilx commented on a change in pull request
#15: MASSEMBLY-922 - allow to override UID/GID for files stored in TAR
Posted by GitBox <gi...@apache.org>.
wilx commented on a change in pull request #15: MASSEMBLY-922 - allow to override UID/GID for files stored in TAR
URL: https://github.com/apache/maven-assembly-plugin/pull/15#discussion_r362070580
##########
File path: src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java
##########
@@ -404,6 +404,32 @@
@Parameter( defaultValue = "${project.build.outputTimestamp}" )
private String outputTimestamp;
+ /**
+ * Override of user ID in archive type which can store it.
+ */
+ @Parameter( property = "assembly.overrideUid" )
Review comment:
All the other properties are just `assembly.*`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-assembly-plugin] eolivelli commented on a change in pull
request #15: MASSEMBLY-922 - allow to override UID/GID for files stored in
TAR
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #15: MASSEMBLY-922 - allow to override UID/GID for files stored in TAR
URL: https://github.com/apache/maven-assembly-plugin/pull/15#discussion_r361963184
##########
File path: src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java
##########
@@ -404,6 +404,32 @@
@Parameter( defaultValue = "${project.build.outputTimestamp}" )
private String outputTimestamp;
+ /**
+ * Override of user ID in archive type which can store it.
+ */
+ @Parameter( property = "assembly.overrideUid" )
Review comment:
Maybe it is better to name it maven.assembly.overrideUid ?
Cc @rfscholte
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-assembly-plugin] wilx commented on a change in pull request
#15: MASSEMBLY-922 - allow to override UID/GID for files stored in TAR
Posted by GitBox <gi...@apache.org>.
wilx commented on a change in pull request #15: MASSEMBLY-922 - allow to override UID/GID for files stored in TAR
URL: https://github.com/apache/maven-assembly-plugin/pull/15#discussion_r362114366
##########
File path: src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java
##########
@@ -404,6 +404,32 @@
@Parameter( defaultValue = "${project.build.outputTimestamp}" )
private String outputTimestamp;
+ /**
+ * Override of user ID in archive type which can store it.
+ */
+ @Parameter( property = "assembly.overrideUid" )
Review comment:
I have removed the property names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-assembly-plugin] rfscholte commented on a change in pull
request #15: MASSEMBLY-922 - allow to override UID/GID for files stored in
TAR
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #15: MASSEMBLY-922 - allow to override UID/GID for files stored in TAR
URL: https://github.com/apache/maven-assembly-plugin/pull/15#discussion_r361965901
##########
File path: src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java
##########
@@ -404,6 +404,32 @@
@Parameter( defaultValue = "${project.build.outputTimestamp}" )
private String outputTimestamp;
+ /**
+ * Override of user ID in archive type which can store it.
+ */
+ @Parameter( property = "assembly.overrideUid" )
Review comment:
Based on https://codehaus-plexus.github.io/plexus-archiver/apidocs/index.html?org/codehaus/plexus/archiver/Archiver.html it makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-assembly-plugin] rfscholte commented on a change in pull
request #15: MASSEMBLY-922 - allow to override UID/GID for files stored in
TAR
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #15: MASSEMBLY-922 - allow to override UID/GID for files stored in TAR
URL: https://github.com/apache/maven-assembly-plugin/pull/15#discussion_r362097949
##########
File path: src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java
##########
@@ -404,6 +404,32 @@
@Parameter( defaultValue = "${project.build.outputTimestamp}" )
private String outputTimestamp;
+ /**
+ * Override of user ID in archive type which can store it.
+ */
+ @Parameter( property = "assembly.overrideUid" )
Review comment:
Is there really a case the you when you need to change it for just one build? To me you want a consistent output, so hence not expose the parameter not with a property.
I noticed that the previous developers were quite enthousiastic with providing properties, but nowadays we're looking more closely if it really makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-assembly-plugin] rfscholte merged pull request #15:
MASSEMBLY-922 - allow to override UID/GID for files stored in TAR
Posted by GitBox <gi...@apache.org>.
rfscholte merged pull request #15: MASSEMBLY-922 - allow to override UID/GID for files stored in TAR
URL: https://github.com/apache/maven-assembly-plugin/pull/15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services