[GitHub] [spark] tgravescs commented on a change in pull request #24374: [WIP][SPARK-27366][CORE] Support GPU Resources in Spark job scheduling

[GitBox <gi...@apache.org>]

tgravescs commented on a change in pull request #24374: [WIP][SPARK-27366][CORE] Support GPU Resources in Spark job scheduling
URL: https://github.com/apache/spark/pull/24374#discussion_r284245322
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/SparkConf.scala
 ##########
 @@ -491,6 +491,101 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging with Seria
     }
   }
 
+  /**
+   * Set available resources on the driver/executor.
+   */
+  private[spark] def setResources(
+      resourceName: String,
+      resourceCount: Int,
+      resourceAddresses: Option[Seq[String]],
 
 Review comment:
   I agree, I'm not sure why we need this in SparkConf, if its just for testing, make it a testing util?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org