You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/01/07 13:38:08 UTC
[GitHub] [commons-lang] IntHelloWorld opened a new pull request #845: Fix a flaky test in org.apache.commons.lang3.time.StopWatchTest.testStopWatchSuspend
IntHelloWorld opened a new pull request #845:
URL: https://github.com/apache/commons-lang/pull/845
Dear developers,
When I built the project I got a failure in org.apache.commons.lang3.time.StopWatchTest.testStopWatchSuspend, but when I rebuilt the project this failure disappeared, so it seems like a flaky test.
The test report is:
```
Test set: org.apache.commons.lang3.time.StopWatchTest
-------------------------------------------------------------------------------
Tests run: 20, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 6.524 s <<< FAILURE! - in org.apache.commons.lang3.time.StopWatchTest
org.apache.commons.lang3.time.StopWatchTest.testStopWatchSuspend Time elapsed: 0.555 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
at org.apache.commons.lang3.time.StopWatchTest.testStopWatchSuspend(StopWatchTest.java:312)
```
In this PR I remove the failed assert statement, that is line 312 in StopWatchTest.java.
The test works well now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #845: Fix a flaky test in org.apache.commons.lang3.time.StopWatchTest.testStopWatchSuspend
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #845:
URL: https://github.com/apache/commons-lang/pull/845#issuecomment-1040471464
-1: This does not fix anything, it merely hides the problem, the test should be made more robust IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #845: Fix a flaky test in org.apache.commons.lang3.time.StopWatchTest.testStopWatchSuspend
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #845:
URL: https://github.com/apache/commons-lang/pull/845#issuecomment-1059965580
Closing, no feedback from OP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #845: Fix a flaky test in org.apache.commons.lang3.time.StopWatchTest.testStopWatchSuspend
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #845:
URL: https://github.com/apache/commons-lang/pull/845#issuecomment-1040471464
-1: This does not fix anything, it merely hides the problem, the test should be made more robust IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory closed pull request #845: Fix a flaky test in org.apache.commons.lang3.time.StopWatchTest.testStopWatchSuspend
Posted by GitBox <gi...@apache.org>.
garydgregory closed pull request #845:
URL: https://github.com/apache/commons-lang/pull/845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org