[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #232: Support waiting for the ACK response

["BewareMyPower (via GitHub)" <gi...@apache.org>]

BewareMyPower commented on code in PR #232:
URL: https://github.com/apache/pulsar-client-cpp/pull/232#discussion_r1150411785


##########
lib/Commands.cc:
##########
@@ -441,15 +442,16 @@ SharedBuffer Commands::newProducer(const std::string& topic, uint64_t producerId
 }
 
 SharedBuffer Commands::newAck(uint64_t consumerId, int64_t ledgerId, int64_t entryId, const BitSet& ackSet,
-                              CommandAck_AckType ackType, CommandAck_ValidationError validationError) {
+                              CommandAck_AckType ackType, uint64_t requestId) {

Review Comment:
   Good find. I think we'd better to use two overloads of `Commands::newAck` to avoid the similar misuse.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org