You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Ruediger Pluem <rp...@apache.org> on 2018/02/16 09:50:20 UTC
Re: svn commit: r1824339 - in /httpd/httpd/trunk: CHANGES
include/ap_regex.h server/core.c server/util_pcre.c
On 02/15/2018 06:53 PM, ylavic@apache.org wrote:
> Author: ylavic
> Date: Thu Feb 15 17:53:24 2018
> New Revision: 1824339
>
> URL: http://svn.apache.org/viewvc?rev=1824339&view=rev
> Log:
> regex: Allow to configure global/default options for regexes.
>
> Like caseless matching or extended format, which may be useful as default
> behaviour the whole configuration.
>
>
> Modified:
> httpd/httpd/trunk/CHANGES
> httpd/httpd/trunk/include/ap_regex.h
> httpd/httpd/trunk/server/core.c
> httpd/httpd/trunk/server/util_pcre.c
Nitpick: Couldn't we replace strcasecmp with ap_cstr_casecmp?
Regards
Rüdiger
Re: svn commit: r1824339 - in /httpd/httpd/trunk: CHANGES
include/ap_regex.h server/core.c server/util_pcre.c
Posted by Yann Ylavic <yl...@gmail.com>.
On Fri, Feb 16, 2018 at 10:50 AM, Ruediger Pluem <rp...@apache.org> wrote:
>
>
> On 02/15/2018 06:53 PM, ylavic@apache.org wrote:
>> Author: ylavic
>> Date: Thu Feb 15 17:53:24 2018
>> New Revision: 1824339
>>
>> URL: http://svn.apache.org/viewvc?rev=1824339&view=rev
>> Log:
>> regex: Allow to configure global/default options for regexes.
>>
>> Like caseless matching or extended format, which may be useful as default
>> behaviour the whole configuration.
>>
>>
>> Modified:
>> httpd/httpd/trunk/CHANGES
>> httpd/httpd/trunk/include/ap_regex.h
>> httpd/httpd/trunk/server/core.c
>> httpd/httpd/trunk/server/util_pcre.c
>
>
> Nitpick: Couldn't we replace strcasecmp with ap_cstr_casecmp?
Sure, r1824439 (backport proposal updated too).
I didn't updated the one in set_regex_default_options() since the
other setters also use strcasecmp(), that'd need its own patch not
really related to the change of this commit...
Thanks for the review!
Regards,
Yann.