[PR] docs(core-spec): escape || so it renders in expression language tables [ossie]

["christianeu-db (via GitHub)" <gi...@apache.org>]

christianeu-db opened a new pull request, #575:
URL: https://github.com/apache/ossie/pull/575

   ## Summary
   
   The `||` string concatenation operator did not render in two tables in
   `core-spec/expression_language.md`. In GitHub-Flavored Markdown, an unescaped
   `|` is a table column delimiter even inside a code span, so each `||` produced
   extra empty columns in its row instead of displaying the operator.
   
   This change escapes the pipe characters as `\|\|`, matching the existing
   convention in `converters/cube/README.md`. It covers both affected tables:
   
   - **String Manipulation (REQUIRED)** — the `||` operator row.
   - **Common Dialect Variations** — the PostgreSQL `a || b` cell.
   
   The ThoughtSpot converter parses this spec file to assert its catalog covers
   every spec construct (`converters/thoughtspot/.../expressions/test_catalog_covers_the_spec.py`),
   and that parser was built around the unescaped `||`. This PR teaches its
   `_clean()` helper to undo the `\|` escape so the extracted construct name stays
   `str1 || str2`. Without that one-line parser change, the escaped source leaks
   backslashes and the coverage test fails.
   
   **This is not a breaking change.** The specification's meaning is unchanged —
   `||` was and remains a supported concatenation operator; only its rendering is
   fixed. The included parser update keeps the ThoughtSpot converter's test suite
   green (`uv run pytest` → 1015 passed).
   
   ## Related Issues
   
   Reported by @Haoranli503 in https://github.com/apache/ossie/pull/547#issuecomment-6127824364.
   
   ## Checklist
   
   ### Specification
   - [x] Spec changes are included in `core-spec/` and follow the existing structure
   - [ ] Spec changes have been discussed on the mailing list or in a linked issue
   - [ ] Breaking changes to the spec are clearly called out in the summary
   
   ### Converters
   - [x] Converter logic in `converters/` is updated to reflect spec or ontology changes
   - [x] New converters include tests under the converter's test directory
   
   ### Tests
   - [x] All existing tests pass (`pytest` / CI green)
   
   > Remaining checklist sections (Ontology, Validation, Documentation, Examples,
   > Compliance) are not applicable: this PR escapes two Markdown table cells and
   > adjusts one parser helper, adding no spec constructs, new files, or
   > dependencies.
   
   ---
   
   This pull request and its description were written by Isaac.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(core-spec): escape || so it renders in expression language tables [ossie]

["jbonofre (via GitHub)" <gi...@apache.org>]

jbonofre merged PR #575:
URL: https://github.com/apache/ossie/pull/575


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org