You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/16 16:26:39 UTC

[GitHub] [flink] zhuzhurk opened a new pull request #12193: [FLINK-17759][runtime] Remove unused RestartIndividualStrategy

zhuzhurk opened a new pull request #12193:
URL: https://github.com/apache/flink/pull/12193


   ## What is the purpose of the change
   
   RestartIndividualStrategy was used by the legacy scheduler and is not used anymore.
   Removing it can ease the work to further remove the legacy scheduling logics in ExecutionGraph.
   
   ## Brief change log
   
   Removed RestartIndividualStrategy.
   This PR is based on #12192
   
   ## Verifying this change
   
   This change is already covered by existing tests
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhuzhurk commented on pull request #12193: [FLINK-17759][runtime] Remove unused RestartIndividualStrategy

Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on pull request #12193:
URL: https://github.com/apache/flink/pull/12193#issuecomment-629920503


   @GJL @tillrohrmann this PR and #12193 are to remove unused legacy failover strategies. 
   There is no behavior change nor interface change.
   Would you take a look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhuzhurk closed pull request #12193: [FLINK-17759][runtime] Remove unused RestartIndividualStrategy

Posted by GitBox <gi...@apache.org>.
zhuzhurk closed pull request #12193:
URL: https://github.com/apache/flink/pull/12193


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12193: [FLINK-17759][runtime] Remove unused RestartIndividualStrategy

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12193:
URL: https://github.com/apache/flink/pull/12193#issuecomment-629673659


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3f6a40a4f0933023bc3172529ed0c7d5a6c422fb",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1569",
       "triggerID" : "3f6a40a4f0933023bc3172529ed0c7d5a6c422fb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3f6a40a4f0933023bc3172529ed0c7d5a6c422fb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1569) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12193: [FLINK-17759][runtime] Remove unused RestartIndividualStrategy

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12193:
URL: https://github.com/apache/flink/pull/12193#issuecomment-629673659


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3f6a40a4f0933023bc3172529ed0c7d5a6c422fb",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1569",
       "triggerID" : "3f6a40a4f0933023bc3172529ed0c7d5a6c422fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a36bef2ce9bc2c3724217931c5d30b212e8ef856",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1671",
       "triggerID" : "a36bef2ce9bc2c3724217931c5d30b212e8ef856",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3f6a40a4f0933023bc3172529ed0c7d5a6c422fb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1569) 
   * a36bef2ce9bc2c3724217931c5d30b212e8ef856 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1671) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhuzhurk commented on pull request #12193: [FLINK-17759][runtime] Remove unused RestartIndividualStrategy

Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on pull request #12193:
URL: https://github.com/apache/flink/pull/12193#issuecomment-630113338


   Thanks for reviewing! @GJL 
   Merging.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12193: [FLINK-17759][runtime] Remove unused RestartIndividualStrategy

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12193:
URL: https://github.com/apache/flink/pull/12193#issuecomment-629673659


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3f6a40a4f0933023bc3172529ed0c7d5a6c422fb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3f6a40a4f0933023bc3172529ed0c7d5a6c422fb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3f6a40a4f0933023bc3172529ed0c7d5a6c422fb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12193: [FLINK-17759][runtime] Remove unused RestartIndividualStrategy

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12193:
URL: https://github.com/apache/flink/pull/12193#issuecomment-629673659


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3f6a40a4f0933023bc3172529ed0c7d5a6c422fb",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1569",
       "triggerID" : "3f6a40a4f0933023bc3172529ed0c7d5a6c422fb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3f6a40a4f0933023bc3172529ed0c7d5a6c422fb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1569) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12193: [FLINK-17759][runtime] Remove unused RestartIndividualStrategy

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12193:
URL: https://github.com/apache/flink/pull/12193#issuecomment-629673659


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3f6a40a4f0933023bc3172529ed0c7d5a6c422fb",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1569",
       "triggerID" : "3f6a40a4f0933023bc3172529ed0c7d5a6c422fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a36bef2ce9bc2c3724217931c5d30b212e8ef856",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a36bef2ce9bc2c3724217931c5d30b212e8ef856",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3f6a40a4f0933023bc3172529ed0c7d5a6c422fb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1569) 
   * a36bef2ce9bc2c3724217931c5d30b212e8ef856 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12193: [FLINK-17759][runtime] Remove unused RestartIndividualStrategy

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12193:
URL: https://github.com/apache/flink/pull/12193#issuecomment-629671260


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit a36bef2ce9bc2c3724217931c5d30b212e8ef856 (Fri Oct 16 10:47:54 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12193: [FLINK-17759][runtime] Remove unused RestartIndividualStrategy

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12193:
URL: https://github.com/apache/flink/pull/12193#issuecomment-629673659


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3f6a40a4f0933023bc3172529ed0c7d5a6c422fb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1569",
       "triggerID" : "3f6a40a4f0933023bc3172529ed0c7d5a6c422fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a36bef2ce9bc2c3724217931c5d30b212e8ef856",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1671",
       "triggerID" : "a36bef2ce9bc2c3724217931c5d30b212e8ef856",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a36bef2ce9bc2c3724217931c5d30b212e8ef856 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1671) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhuzhurk edited a comment on pull request #12193: [FLINK-17759][runtime] Remove unused RestartIndividualStrategy

Posted by GitBox <gi...@apache.org>.
zhuzhurk edited a comment on pull request #12193:
URL: https://github.com/apache/flink/pull/12193#issuecomment-629920503


   @GJL @tillrohrmann this PR and #12192 are to remove unused legacy failover strategies. 
   There is no behavior change nor interface change.
   Would you take a look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12193: [FLINK-17759][runtime] Remove unused RestartIndividualStrategy

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12193:
URL: https://github.com/apache/flink/pull/12193#issuecomment-629671260


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 3f6a40a4f0933023bc3172529ed0c7d5a6c422fb (Sat May 16 16:29:15 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhuzhurk commented on pull request #12193: [FLINK-17759][runtime] Remove unused RestartIndividualStrategy

Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on pull request #12193:
URL: https://github.com/apache/flink/pull/12193#issuecomment-630079861


   The failed test `PerformUnalignedCheckpointOnParallelRemoteChannel` is unrelated. (see FLINK-17768)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org