You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "janhoy (via GitHub)" <gi...@apache.org> on 2023/03/23 07:53:35 UTC

[GitHub] [solr] janhoy opened a new pull request, #1486: Update major-changes-in-solr-9.adoc

janhoy opened a new pull request, #1486:
URL: https://github.com/apache/solr/pull/1486

   Re-arranging some upgrade notes
   
   While reviewing the 9.2 release, I started reading release notes and found that two of my own deprecations notes were listed under a Jetty heading. Thus I added a new `Deprecations` heading and moved things around.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] janhoy commented on a diff in pull request #1486: SOLR-16708: Update major-changes-in-solr-9.adoc

Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on code in PR #1486:
URL: https://github.com/apache/solr/pull/1486#discussion_r1146532860


##########
solr/solr-ref-guide/modules/upgrade-notes/pages/solr-upgrade-notes.adoc:
##########
@@ -35,18 +34,29 @@ that may affect your existing implementation.
 
 Detailed steps for upgrading a Solr cluster are in the section xref:deployment-guide:upgrading-a-solr-cluster.adoc[].
 
-// DO NOT ADD MINOR VERSION INFO HERE; see child pages
+== How to use the Major Changes pages
+
+The Major Changes pages are grouped in two ways:
+- For Solr versions `9.y+`:
+  The `Major Changes in Solr _x_` (e.g. xref:major-changes-in-solr-9.adoc[]) pages include all changes included in any `x.y` release.
+  Therefore xref:major-changes-in-solr-9.adoc[] includes all changes in any Solr `9.x` release.
+- For Solr versions `6.y`-`8.y`:
+  The `Major Changes in Solr _x_` (e.g. xref:major-changes-in-solr-8.adoc[]) pages include all changes from Solr `_(x-1)_.0` to Solr `_x_.0`.
+  Therefore xref:major-changes-in-solr-8.adoc[] includes all changes from Solr `7.0` to Solr `8.0`, starting wil Solr `7.1`.
+
+In these pages, the first section describes planning for an upgrade from to that major version from the previous major version,

Review Comment:
   From to…



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] HoustonPutman commented on a diff in pull request #1486: SOLR-16708: Update major-changes-in-solr-9.adoc

Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on code in PR #1486:
URL: https://github.com/apache/solr/pull/1486#discussion_r1146568163


##########
solr/solr-ref-guide/modules/upgrade-notes/pages/solr-upgrade-notes.adoc:
##########
@@ -35,18 +34,29 @@ that may affect your existing implementation.
 
 Detailed steps for upgrading a Solr cluster are in the section xref:deployment-guide:upgrading-a-solr-cluster.adoc[].
 
-// DO NOT ADD MINOR VERSION INFO HERE; see child pages
+== How to use the Major Changes pages
+
+The Major Changes pages are grouped in two ways:
+- For Solr versions `9.y+`:
+  The `Major Changes in Solr _x_` (e.g. xref:major-changes-in-solr-9.adoc[]) pages include all changes included in any `x.y` release.
+  Therefore xref:major-changes-in-solr-9.adoc[] includes all changes in any Solr `9.x` release.
+- For Solr versions `6.y`-`8.y`:
+  The `Major Changes in Solr _x_` (e.g. xref:major-changes-in-solr-8.adoc[]) pages include all changes from Solr `_(x-1)_.0` to Solr `_x_.0`.
+  Therefore xref:major-changes-in-solr-8.adoc[] includes all changes from Solr `7.0` to Solr `8.0`, starting wil Solr `7.1`.
+
+In these pages, the first section describes planning for an upgrade from to that major version from the previous major version,

Review Comment:
   thanks for catching this!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] HoustonPutman merged pull request #1486: SOLR-16708: Update major-changes-in-solr-9.adoc

Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman merged PR #1486:
URL: https://github.com/apache/solr/pull/1486


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] HoustonPutman commented on pull request #1486: SOLR-16708: Update major-changes-in-solr-9.adoc

Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on PR #1486:
URL: https://github.com/apache/solr/pull/1486#issuecomment-1481505547

   Let me know what you think of that @janhoy


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] janhoy commented on pull request #1486: Update major-changes-in-solr-9.adoc

Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #1486:
URL: https://github.com/apache/solr/pull/1486#issuecomment-1480740326

   Another thing I noticed is that CHANGES.txt on the top link to https://github.com/apache/solr/blob/main/solr/solr-ref-guide/modules/upgrade-notes/pages/solr-upgrade-notes.adoc, but that page does not contain the 9.2 release notes, and the link to the 9.x release notes page is only found below a heading `Upgrading to 9.0 from 8.x Releases`.
   
   So I think that landing page also needs some love...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org