You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "YinkaMetrics (via GitHub)" <gi...@apache.org> on 2026/07/02 02:56:30 UTC
[PR] fix(dashboard): use theme border for chart tiles [superset]
YinkaMetrics opened a new pull request, #41661:
URL: https://github.com/apache/superset/pull/41661
### SUMMARY
- add a resting chart tile border using the active theme colorBorder token
- keep the existing border radius token on chart holders
- add DashboardBuilder coverage for the chart holder border styles
Closes #41618
### TESTING INSTRUCTIONS
- env NODE_ENV=test NODE_OPTIONS=--max-old-space-size=8192 node_modules/.bin/jest --config jest.config.js --silent --runInBand src/dashboard/components/DashboardBuilder/DashboardBuilder.test.tsx
- superset-frontend/node_modules/.bin/prettier --check superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.test.tsx
- git diff --check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): use theme border for chart tiles [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41661:
URL: https://github.com/apache/superset/pull/41661#issuecomment-4877136143
<!-- Bito Reply -->
To resolve the failing pre-commit check, you need to run the project's Prettier formatting command locally. Since the `prettier-frontend` hook identified that `superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx` requires reformatting, please execute the following command in your terminal:
```bash
npm run prettier -- --write superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
```
After running this command, stage the changes and push them to your branch. This will ensure the file adheres to the project's style guidelines and allow the pre-commit check to pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): use theme border for chart tiles [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on code in PR #41661:
URL: https://github.com/apache/superset/pull/41661#discussion_r3520395134
##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx:
##########
@@ -317,6 +317,10 @@ const StyledDashboardContent = styled.div<{
width: 100%;
height: 100%;
background-color: ${theme.dashboardTileBg ?? theme.colorBgContainer};
+ border: ${theme.dashboardTileBorder ??
Review Comment:
HIGH: the `pre-commit (current)` required check is failing at this HEAD — `prettier-frontend` reformats this file (`files were modified by this hook`). Run `prettier --write` (or the repo's pre-commit hook) locally and push the formatted version; this blocks merge as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): use theme border for chart tiles [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41661:
URL: https://github.com/apache/superset/pull/41661#issuecomment-4861766682
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): use theme border for chart tiles [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41661:
URL: https://github.com/apache/superset/pull/41661#issuecomment-4879468726
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): use theme border for chart tiles [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #41661:
URL: https://github.com/apache/superset/pull/41661#issuecomment-4885052083
Thanks @YinkaMetrics, you got to the right approach first here (the `dashboardTileBorder ?? colorBorder` fallback seems right). But #41731 landed the same change with green CI and a bit more test coverage, so we're likely to merge that one and close this. Let me know if I'm misconstruing anything, and thanks for this and future contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): use theme border for chart tiles [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #41661:
URL: https://github.com/apache/superset/pull/41661#issuecomment-4885057516
Merged #41731, so I'll indeed close this after all, but let me know if you think there's more to address, and we can certainly reopen/revisit this. Thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): use theme border for chart tiles [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #41661:
URL: https://github.com/apache/superset/pull/41661#issuecomment-4878647631
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 744d526edffa689dbb725390bce4c7df69108b7b |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a480087f900e400087b33bb |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-41661--superset-docs-preview.netlify.app](https://deploy-preview-41661--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#FcrLCYAwDADQXXJWDLRodQPHSEyl4iclehFxd-vtHd4D2XTPFwwAFbDRMaXiezlWaoTOxEom9ZTIrprVJFp5EvOm9yhltuQDYujmHjF6_MnOMcP7AQ) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-41661--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): use theme border for chart tiles [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #41661: fix(dashboard): use theme border for chart tiles
URL: https://github.com/apache/superset/pull/41661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org