You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Andrei Savu (JIRA)" <ji...@apache.org> on 2011/04/28 16:51:03 UTC

[jira] [Created] (WHIRR-289) Display role names in list-cluster command

Display role names in list-cluster command
------------------------------------------

                 Key: WHIRR-289
                 URL: https://issues.apache.org/jira/browse/WHIRR-289
             Project: Whirr
          Issue Type: Improvement
            Reporter: Andrei Savu
            Assignee: Andrei Savu
             Fix For: 0.5.0


List cluster should also display role names for each node. This feature is going to be really useful when the cluster state is no longer persisted on the local machine. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (WHIRR-289) Display role names in list-cluster command

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Savu updated WHIRR-289:
------------------------------

    Attachment: WHIRR-289.patch

Trivial patch tested on ec2. 

> Display role names in list-cluster command
> ------------------------------------------
>
>                 Key: WHIRR-289
>                 URL: https://issues.apache.org/jira/browse/WHIRR-289
>             Project: Whirr
>          Issue Type: Improvement
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.5.0
>
>         Attachments: WHIRR-289.patch
>
>
> List cluster should also display role names for each node. This feature is going to be really useful when the cluster state is no longer persisted on the local machine. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WHIRR-289) Display role names in list-cluster command

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WHIRR-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026687#comment-13026687 ] 

Tom White commented on WHIRR-289:
---------------------------------

+1

> Display role names in list-cluster command
> ------------------------------------------
>
>                 Key: WHIRR-289
>                 URL: https://issues.apache.org/jira/browse/WHIRR-289
>             Project: Whirr
>          Issue Type: Improvement
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.5.0
>
>         Attachments: WHIRR-289.patch, WHIRR-289.patch
>
>
> List cluster should also display role names for each node. This feature is going to be really useful when the cluster state is no longer persisted on the local machine. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WHIRR-289) Display role names in list-cluster command

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WHIRR-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026382#comment-13026382 ] 

Tom White commented on WHIRR-289:
---------------------------------

We could do this by adding a getInstances() method and deprecating getNodes().

> Display role names in list-cluster command
> ------------------------------------------
>
>                 Key: WHIRR-289
>                 URL: https://issues.apache.org/jira/browse/WHIRR-289
>             Project: Whirr
>          Issue Type: Improvement
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.5.0
>
>         Attachments: WHIRR-289.patch
>
>
> List cluster should also display role names for each node. This feature is going to be really useful when the cluster state is no longer persisted on the local machine. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (WHIRR-289) Display role names in list-cluster command

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Savu updated WHIRR-289:
------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I've just committed this. Tom, thanks for taking the time to review. 

> Display role names in list-cluster command
> ------------------------------------------
>
>                 Key: WHIRR-289
>                 URL: https://issues.apache.org/jira/browse/WHIRR-289
>             Project: Whirr
>          Issue Type: Improvement
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.5.0
>
>         Attachments: WHIRR-289.patch, WHIRR-289.patch
>
>
> List cluster should also display role names for each node. This feature is going to be really useful when the cluster state is no longer persisted on the local machine. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (WHIRR-289) Display role names in list-cluster command

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Savu updated WHIRR-289:
------------------------------

    Attachment: WHIRR-289.patch

Updated patch. Tom, let me know what you think. 

> Display role names in list-cluster command
> ------------------------------------------
>
>                 Key: WHIRR-289
>                 URL: https://issues.apache.org/jira/browse/WHIRR-289
>             Project: Whirr
>          Issue Type: Improvement
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.5.0
>
>         Attachments: WHIRR-289.patch, WHIRR-289.patch
>
>
> List cluster should also display role names for each node. This feature is going to be really useful when the cluster state is no longer persisted on the local machine. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (WHIRR-289) Display role names in list-cluster command

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Savu updated WHIRR-289:
------------------------------

    Status: Patch Available  (was: Open)

> Display role names in list-cluster command
> ------------------------------------------
>
>                 Key: WHIRR-289
>                 URL: https://issues.apache.org/jira/browse/WHIRR-289
>             Project: Whirr
>          Issue Type: Improvement
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.5.0
>
>         Attachments: WHIRR-289.patch
>
>
> List cluster should also display role names for each node. This feature is going to be really useful when the cluster state is no longer persisted on the local machine. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WHIRR-289) Display role names in list-cluster command

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WHIRR-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026381#comment-13026381 ] 

Tom White commented on WHIRR-289:
---------------------------------

How about changing ClusterController.getNodes() to return Cluster.Instance objects? It shouldn't really be returning NodeMetadata in the public interface anyway, and making this change would help other callers of the interface (so they can find roles), not just the CLI.

> Display role names in list-cluster command
> ------------------------------------------
>
>                 Key: WHIRR-289
>                 URL: https://issues.apache.org/jira/browse/WHIRR-289
>             Project: Whirr
>          Issue Type: Improvement
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.5.0
>
>         Attachments: WHIRR-289.patch
>
>
> List cluster should also display role names for each node. This feature is going to be really useful when the cluster state is no longer persisted on the local machine. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WHIRR-289) Display role names in list-cluster command

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WHIRR-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026402#comment-13026402 ] 

Andrei Savu commented on WHIRR-289:
-----------------------------------

Great idea! I will update the code.

> Display role names in list-cluster command
> ------------------------------------------
>
>                 Key: WHIRR-289
>                 URL: https://issues.apache.org/jira/browse/WHIRR-289
>             Project: Whirr
>          Issue Type: Improvement
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.5.0
>
>         Attachments: WHIRR-289.patch
>
>
> List cluster should also display role names for each node. This feature is going to be really useful when the cluster state is no longer persisted on the local machine. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira