[incubator-mxnet] branch master updated: fix parameter overwrite in _generate_symbol_function_code (#9180)

[jx...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jxie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git


The following commit(s) were added to refs/heads/master by this push:
     new 01a2a40  fix parameter overwrite in _generate_symbol_function_code (#9180)
01a2a40 is described below

commit 01a2a40d5b2cb3dd250f4e4033d896380e1354bd
Author: viking <au...@gmail.com>
AuthorDate: Thu Dec 28 03:43:46 2017 +0800

    fix parameter overwrite in _generate_symbol_function_code (#9180)
    
    * fix parameter overwrite in _generate_symbol_function_code
    
    * fix keys missing problem introduced by previous commit
---
 python/mxnet/symbol/register.py | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/python/mxnet/symbol/register.py b/python/mxnet/symbol/register.py
index cf279d1..7b293f5 100644
--- a/python/mxnet/symbol/register.py
+++ b/python/mxnet/symbol/register.py
@@ -143,14 +143,14 @@ def %s(%s):"""%(func_name, ', '.join(signature)))
             code.append("""
     kwargs.update(AttrScope.current.get(attr))
     sym_kwargs = dict()
-    keys = []
-    vals = []
-    for k, v in kwargs.items():
-        if isinstance(v, SymbolBase):
-            sym_kwargs[k] = v
+    _keys = []
+    _vals = []
+    for _k, _v in kwargs.items():
+        if isinstance(_v, SymbolBase):
+            sym_kwargs[_k] = _v
         else:
-            keys.append(k)
-            vals.append(v)""")
+            _keys.append(_k)
+            _vals.append(_v)""")
             # NDArray args
             for name in ndarg_names: # pylint: disable=redefined-argument-from-local
                 code.append("""
@@ -162,18 +162,18 @@ def %s(%s):"""%(func_name, ', '.join(signature)))
             for name in kwarg_names: # pylint: disable=redefined-argument-from-local
                 code.append("""
     if %s is not _Null:
-        keys.append('%s')
-        vals.append(%s)"""%(name, name, name))
+        _keys.append('%s')
+        _vals.append(%s)"""%(name, name, name))
             # dtype
             if dtype_name is not None:
                 code.append("""
     if %s is not _Null:
-        keys.append('%s')
-        vals.append(np.dtype(%s).name)"""%(dtype_name, dtype_name, dtype_name))
+        _keys.append('%s')
+        _vals.append(np.dtype(%s).name)"""%(dtype_name, dtype_name, dtype_name))
 
             code.append("""
     name = NameManager.current.get(name, '%s')
-    return _symbol_creator(%d, None, sym_kwargs, keys, vals, name)"""%(
+    return _symbol_creator(%d, None, sym_kwargs, _keys, _vals, name)"""%(
         func_name.lower(), handle.value))
 
     if signature_only:

-- 
To stop receiving notification emails like this one, please contact
['"commits@mxnet.apache.org" <co...@mxnet.apache.org>'].